chore(js): Remove live = 'rejectOnError' option
#2971
+36
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 19, 2025
Member
Author
szokeasaurusrex
added a commit
that referenced
this pull request
Nov 19, 2025
### Description We added the `live = 'rejectOnError'` option in #2605 with the intention to make the behavior provided by setting `live = 'rejectOnError'` the default behavior of setting `live = true` in the next major. ### Issues - Resolves #2606 - Resolves [CLI-138](https://linear.app/getsentry/issue/CLI-138/v3-fix-js-interface-execute-promise-resolve-values)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/no-live-rejectOnError
branch
from
abf71f3 to
6b12318
Compare
szokeasaurusrex
requested review from
AbhiPrasad and
s1gr1d
and removed request for
a team,
AbhiPrasad and
s1gr1d
loewenheim
approved these changes
Nov 19, 2025
szokeasaurusrex
added a commit
that referenced
this pull request
Nov 19, 2025
### Description We added the `live = 'rejectOnError'` option in #2605 with the intention to make the behavior provided by setting `live = 'rejectOnError'` the default behavior of setting `live = true` in the next major. ### Issues - Resolves #2606 - Resolves [CLI-138](https://linear.app/getsentry/issue/CLI-138/v3-fix-js-interface-execute-promise-resolve-values)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/no-live-rejectOnError
branch
from
6b12318 to
40b77a1
Compare
This was referenced Nov 19, 2025
### Description We added the `live = 'rejectOnError'` option in #2605 with the intention to make the behavior provided by setting `live = 'rejectOnError'` the default behavior of setting `live = true` in the next major. ### Issues - Resolves #2606 - Resolves [CLI-138](https://linear.app/getsentry/issue/CLI-138/v3-fix-js-interface-execute-promise-resolve-values)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/no-live-rejectOnError
branch
from
40b77a1 to
bd678cf
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/no-release-bundle-uploads
branch
from
3d01060 to
002c166
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // TODO (v3): Clean this up and always resolve a string (or change the type definition) | ||
| // @ts-expect-error - see comment above | ||
| resolve(); | ||
| reject(new Error(`Command ${args.join(' ')} failed with exit code ${exitCode}`)); |
There was a problem hiding this comment.
Bug: Missing else causes reject after successful resolve
The exit handler unconditionally calls reject() after conditionally calling resolve() for zero exit codes. When exitCode === 0, both resolve('success (live mode)') and reject(new Error(...)) execute sequentially. While promises only settle once, this creates an unhandled rejection and indicates incorrect control flow logic. An else clause or return statement is needed to prevent rejection after successful resolution.
szokeasaurusrex
added
the
v3.0
JPeer264
reviewed
Nov 26, 2025
| * | ||
| * @param {string} release Unique name of the release. | ||
| * @param {SentryCliUploadSourceMapsOptions & {live?: boolean | 'rejectOnError'}} options Options to configure the source map upload. | ||
| * @param {SentryCliUploadSourceMapsOptions} options Options to configure the source map upload. |
Member
There was a problem hiding this comment.
@szokeasaurusrex Here the live option is entirely removed, but in types.ts the live option is just adapted. What is now true?
Member
Author
There was a problem hiding this comment.
Yes, exactly, this removal is intentional. For sourcemaps upload, we always use live = true, and there is no way to override this (this is actually what we had prior to introducing the 'rejectOnError' option; we only made live configurable here to allow us to use 'rejectOnError').
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We added the
live = 'rejectOnError'option in #2605 with the intention to make the behavior provided by settinglive = 'rejectOnError'the default behavior of settinglive = truein the next major.Issues
executepromise resolve values #2606