ref(proguard): Redeclare mappings as immutable
#2896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2025
Member
Author
szokeasaurusrex
requested review from
a team and
loewenheim
and removed request for
a team
loewenheim
approved these changes
Oct 30, 2025
To make it easier to reason about the code when working on #2328, we redeclare the `mappings` variable as immutable after we are done constructing it.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/immutable-mappings
branch
from
23eae8b to
4cda688
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/server-options-nonzerousize
branch
from
e747c77 to
07fb49f
Compare
Base automatically changed from
szokeasaurusrex/server-options-nonzerousize
to
master
November 3, 2025 10:59
This was referenced Nov 6, 2025
This was referenced Nov 13, 2025
This was referenced Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To make it easier to reason about the code when working on #2328, we redeclare the
mappingsvariable as immutable after we are done constructing it.Issues