-
-
Notifications
You must be signed in to change notification settings - Fork 236
chore: Drop Node <18 support #2986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3
Are you sure you want to change the base?
Conversation
|
Hm, don't think we can/should do this. The CLI is used by our bundler plugins which are used by our SDKs which still support node 18 🤔. |
|
Very good point @andreiborza - Node 18 is good as well |
3957ec7 to
5ecad6f
Compare
andreiborza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You typod the node version in the win32-x64 json, otherwise LGTM.
Should the base branch be master tho? How are you and @szokeasaurusrex handling v3?
|
@andreiborza I have a PR stack for the 3.0 major. Currently the top PR is #2973. I see two options for how we handle this: either we can have a separate PR stack for the JS API changes, which we can merge together at the end. This could make sense as we hopefully will not have too many conflicts at the merge. The other option is we add this PR to my stack. That avoids merge conflicts in the future. In that case, I would take over managing this PR's branch once we agree it is ready, as the PR stacking process requires a rebase/force push workflow. Which would y'all prefer? |
|
@szokeasaurusrex I leave that up to you and @JPeer264, personally I'd add this to your stack. |
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
@JPeer264, I have added some suggestions. Once you have finalized your changes, please rebase on top of the |
a9f9165 to
a809a5c
Compare
closes #2985
This will ensure that in the future don't have to work around certain features which are not available in older Node versions.