Skip to content

ref(chunks): Use NonZeroUsize in Chunked type #2894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2025
Merged

ref(chunks): Use NonZeroUsize in Chunked type #2894

merged 1 commit into from
Nov 3, 2025
+14 −13

Conversation

@szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Oct 30, 2025 •
edited
Loading

Description

This allows us to avoid returning Result in Chunked::from.

Issues

@szokeasaurusrex szokeasaurusrex mentioned this pull request Oct 30, 2025
Merged
@szokeasaurusrex Graphite App
Copy link
Member Author

szokeasaurusrex commented Oct 30, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@szokeasaurusrex szokeasaurusrex mentioned this pull request Oct 30, 2025
Merged
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review October 30, 2025 14:38
@szokeasaurusrex szokeasaurusrex requested a review from a team as a code owner October 30, 2025 14:38
This was referenced Oct 30, 2025
Open
Merged
loewenheim
loewenheim approved these changes Nov 3, 2025
View reviewed changes
Copy link
Contributor

@loewenheim loewenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but couldn't you also use a NonZero type in the options?

@szokeasaurusrex
Copy link
Member Author

szokeasaurusrex commented Nov 3, 2025

@loewenheim yep, I did that in the next PR, which you already approved: #2895 (it was kinda a lot of things to do in a single PR)

@szokeasaurusrex
ref(chunks): Use NonZeroUsize in Chunked type
5b3a9bf 
This allows us to avoid returning `Result` in `Chunked::from`.
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/chunks-from-infallible branch from 5345e5d to 5b3a9bf Compare November 3, 2025 10:53
@szokeasaurusrex szokeasaurusrex force-pushed the 10-30-ref_chunks_get_sha1_checksums_infallible branch from f491da4 to 3d82836 Compare November 3, 2025 10:53
Base automatically changed from 10-30-ref_chunks_get_sha1_checksums_infallible to master November 3, 2025 10:58
@szokeasaurusrex szokeasaurusrex merged commit 5b3a9bf into master Nov 3, 2025
29 of 49 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/chunks-from-infallible branch November 3, 2025 10:59
This was referenced Nov 6, 2025
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 13, 2025
Open
Open
Open
Open
Open
Open
Open
@szokeasaurusrex szokeasaurusrex mentioned this pull request Nov 19, 2025
Open
@szokeasaurusrex szokeasaurusrex mentioned this pull request Nov 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loewenheim loewenheim loewenheim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@szokeasaurusrex @loewenheim