fix: CaptureFeedback now applies event processors by jamescrosswell · Pull Request #4942 · getsentry/sentry-dotnet

jamescrosswell · 2026-02-23T00:33:16Z

CaptureFeedback, missing environment #4808

github-actions · 2026-02-23T00:33:38Z

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

Breaking Changes 🛠

The _Metrics_ APIs are now stable: removed Experimental from SentrySdk, SentryOptions and IHub by Flash0ver in #5023

Fixes 🐛

fix: CaptureFeedback now applies event processors by jamescrosswell in #4942

Dependencies ⬆️

Deps

chore(deps): update Java SDK to v8.35.0 by github-actions in #5017
chore(deps): replaced the heavy protobuf-javalite 3.25.8 dependency with a light-weight epitaph 0.1.0 alternative on Android (getsentry/sentry-java#5157) by github-actions in #5017
chore(deps): update CLI to v3.3.3 by github-actions in #5002
chore(deps): update Cocoa SDK to v9.6.0 by github-actions in #4958

_{🤖 This preview updates automatically when you update the PR.}

src/Sentry/SentryClient.cs

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

src/Sentry/Internal/SentryEventHelper.cs

codecov · 2026-02-24T01:59:19Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.92%. Comparing base (6ca6d96) to head (9966ca4).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4942      +/-   ##
==========================================
- Coverage   73.94%   73.92%   -0.02%     
==========================================
  Files         497      497              
  Lines       17969    17975       +6     
  Branches     3517     3518       +1     
==========================================
+ Hits        13287    13288       +1     
- Misses       3825     3832       +7     
+ Partials      857      855       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

src/Sentry/SentryClient.cs

CHANGELOG.md

test/Sentry.Tests/SentryClientTests.cs

src/Sentry/SentryClient.cs

CHANGELOG.md

Co-authored-by: Stefan Pölz <38893694+Flash0ver@users.noreply.github.com>

Flash0ver

One final suggestion.
Also - we now got a merge conflict ... sorry it took so long.

test/Sentry.Tests/SentryClientTests.cs

Co-authored-by: Stefan Pölz <38893694+Flash0ver@users.noreply.github.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Sentry.Maui](https://sentry.io/) ([source](https://github.com/getsentry/sentry-dotnet)) | nuget | minor | `6.2.0` -> `6.3.0` | --- ### Release Notes <details> <summary>getsentry/sentry-dotnet (Sentry.Maui)</summary> ### [`v6.3.0`](https://github.com/getsentry/sentry-dotnet/blob/HEAD/CHANGELOG.md#630) [Compare Source](getsentry/sentry-dotnet@6.2.0...6.3.0) ##### Features - The *Metrics* APIs are now stable: removed `Experimental` from `SentrySdk`, `SentryOptions` and `IHub` ([#5023](getsentry/sentry-dotnet#5023)) - Report a new *Diagnostic* (`SENTRY1001`) when a Metrics-API is invoked with an unsupported numeric type ([#4840](getsentry/sentry-dotnet#4840)) ##### Fixes - Common tags such as `Environment` and `Release` and custom event processors are all now correctly applied to CaptureFeedback events ([#4942](getsentry/sentry-dotnet#4942)) - Include `Data` set via `ITransactionTracer` in `SentryTransaction` ([#4148](getsentry/sentry-dotnet#4148)) ##### Dependencies - Bump Cocoa SDK from v9.5.0 to v9.7.0 ([#4958](getsentry/sentry-dotnet#4958), [#5015](getsentry/sentry-dotnet#5015)) - Bump CLI from v3.3.0 to v3.3.3 ([#5002](getsentry/sentry-dotnet#5002)) - Bump Java SDK from v8.34.1 to v8.35.0 ([#5017](getsentry/sentry-dotnet#5017)) - Bump Native SDK from v0.13.2 to v0.13.3 ([#5045](getsentry/sentry-dotnet#5045)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or PR is renamed to start with "rebase!". 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

…3244) Pinned [Sentry.AspNetCore](https://github.com/getsentry/sentry-dotnet) at 6.3.0. <details> <summary>Release notes</summary> _Sourced from [Sentry.AspNetCore's releases](https://github.com/getsentry/sentry-dotnet/releases)._ ## 6.3.0 ### Features - The _Metrics_ APIs are now stable: removed `Experimental` from `SentrySdk`, `SentryOptions` and `IHub` ([#5023](getsentry/sentry-dotnet#5023)) - Report a new _Diagnostic_ (`SENTRY1001`) when a Metrics-API is invoked with an unsupported numeric type ([#4840](getsentry/sentry-dotnet#4840)) ### Fixes - Common tags such as `Environment` and `Release` and custom event processors are all now correctly applied to CaptureFeedback events ([#4942](getsentry/sentry-dotnet#4942)) - Include `Data` set via `ITransactionTracer` in `SentryTransaction` ([#4148](getsentry/sentry-dotnet#4148)) ### Dependencies - Bump Cocoa SDK from v9.5.0 to v9.7.0 ([#4958](getsentry/sentry-dotnet#4958), [#5015](getsentry/sentry-dotnet#5015)) - Bump CLI from v3.3.0 to v3.3.3 ([#5002](getsentry/sentry-dotnet#5002)) - Bump Java SDK from v8.34.1 to v8.35.0 ([#5017](getsentry/sentry-dotnet#5017)) - Bump Native SDK from v0.13.2 to v0.13.3 ([#5045](getsentry/sentry-dotnet#5045)) Commits viewable in [compare view](getsentry/sentry-dotnet@6.2.0...6.3.0). </details> Updated [Sentry.Extensions.Logging](https://github.com/getsentry/sentry-dotnet) from 6.2.0 to 6.3.0. <details> <summary>Release notes</summary> _Sourced from [Sentry.Extensions.Logging's releases](https://github.com/getsentry/sentry-dotnet/releases)._ ## 6.3.0 ### Features - The _Metrics_ APIs are now stable: removed `Experimental` from `SentrySdk`, `SentryOptions` and `IHub` ([#5023](getsentry/sentry-dotnet#5023)) - Report a new _Diagnostic_ (`SENTRY1001`) when a Metrics-API is invoked with an unsupported numeric type ([#4840](getsentry/sentry-dotnet#4840)) ### Fixes - Common tags such as `Environment` and `Release` and custom event processors are all now correctly applied to CaptureFeedback events ([#4942](getsentry/sentry-dotnet#4942)) - Include `Data` set via `ITransactionTracer` in `SentryTransaction` ([#4148](getsentry/sentry-dotnet#4148)) ### Dependencies - Bump Cocoa SDK from v9.5.0 to v9.7.0 ([#4958](getsentry/sentry-dotnet#4958), [#5015](getsentry/sentry-dotnet#5015)) - Bump CLI from v3.3.0 to v3.3.3 ([#5002](getsentry/sentry-dotnet#5002)) - Bump Java SDK from v8.34.1 to v8.35.0 ([#5017](getsentry/sentry-dotnet#5017)) - Bump Native SDK from v0.13.2 to v0.13.3 ([#5045](getsentry/sentry-dotnet#5045)) Commits viewable in [compare view](getsentry/sentry-dotnet@6.2.0...6.3.0). </details> Pinned [Sentry.Serilog](https://github.com/getsentry/sentry-dotnet) at 6.3.0. <details> <summary>Release notes</summary> _Sourced from [Sentry.Serilog's releases](https://github.com/getsentry/sentry-dotnet/releases)._ ## 6.3.0 ### Features - The _Metrics_ APIs are now stable: removed `Experimental` from `SentrySdk`, `SentryOptions` and `IHub` ([#5023](getsentry/sentry-dotnet#5023)) - Report a new _Diagnostic_ (`SENTRY1001`) when a Metrics-API is invoked with an unsupported numeric type ([#4840](getsentry/sentry-dotnet#4840)) ### Fixes - Common tags such as `Environment` and `Release` and custom event processors are all now correctly applied to CaptureFeedback events ([#4942](getsentry/sentry-dotnet#4942)) - Include `Data` set via `ITransactionTracer` in `SentryTransaction` ([#4148](getsentry/sentry-dotnet#4148)) ### Dependencies - Bump Cocoa SDK from v9.5.0 to v9.7.0 ([#4958](getsentry/sentry-dotnet#4958), [#5015](getsentry/sentry-dotnet#5015)) - Bump CLI from v3.3.0 to v3.3.3 ([#5002](getsentry/sentry-dotnet#5002)) - Bump Java SDK from v8.34.1 to v8.35.0 ([#5017](getsentry/sentry-dotnet#5017)) - Bump Native SDK from v0.13.2 to v0.13.3 ([#5045](getsentry/sentry-dotnet#5045)) Commits viewable in [compare view](getsentry/sentry-dotnet@6.2.0...6.3.0). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

CaptureFeedback now applies event processors

3400f00

fixes #4808

Format code

e36fe48

jamescrosswell marked this pull request as ready for review February 23, 2026 01:31

jamescrosswell requested a review from Flash0ver as a code owner February 23, 2026 01:31

jamescrosswell assigned Flash0ver Feb 23, 2026

cursor bot reviewed Feb 23, 2026

View reviewed changes

src/Sentry/SentryClient.cs Show resolved Hide resolved

Changelog

701429a

cursor bot reviewed Feb 24, 2026

View reviewed changes

src/Sentry/SentryClient.cs Show resolved Hide resolved

Fixed data category on dropped feedback events

b2508fa

cursor bot reviewed Feb 24, 2026

View reviewed changes

src/Sentry/Internal/SentryEventHelper.cs Show resolved Hide resolved

.

00bc7d1

Flash0ver reviewed Mar 4, 2026

View reviewed changes

src/Sentry/SentryClient.cs Outdated Show resolved Hide resolved

src/Sentry/SentryClient.cs Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

test/Sentry.Tests/SentryClientTests.cs Outdated Show resolved Hide resolved

jamescrosswell commented Mar 5, 2026

View reviewed changes

src/Sentry/SentryClient.cs Outdated Show resolved Hide resolved

Added new error reason for event processors

bc250b9

sentry bot reviewed Mar 5, 2026

View reviewed changes

src/Sentry/SentryClient.cs Show resolved Hide resolved

jamescrosswell commented Mar 5, 2026

View reviewed changes

src/Sentry/SentryClient.cs Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

jamescrosswell and others added 4 commits March 5, 2026 15:29

Apply suggestions from code review

355598b

Co-authored-by: Stefan Pölz <38893694+Flash0ver@users.noreply.github.com>

Apply suggestion from @jamescrosswell

1610548

Verify tests

e710942

Windows verify tests

2666e73

jamescrosswell requested a review from Flash0ver March 5, 2026 22:38

Flash0ver reviewed Mar 16, 2026

View reviewed changes

test/Sentry.Tests/SentryClientTests.cs Show resolved Hide resolved

jamescrosswell and others added 2 commits March 17, 2026 13:16

Update test/Sentry.Tests/SentryClientTests.cs

1a76d32

Co-authored-by: Stefan Pölz <38893694+Flash0ver@users.noreply.github.com>

Merge branch 'main' into feedback-environment

9966ca4

jamescrosswell requested a review from Flash0ver March 17, 2026 00:20

Flash0ver approved these changes Mar 17, 2026

View reviewed changes

Flash0ver merged commit a7615cf into main Mar 17, 2026
41 checks passed

Flash0ver deleted the feedback-environment branch March 17, 2026 10:55

bitsandfoxes mentioned this pull request Mar 19, 2026

chore: Removed redundant enrichting during feedback processing #5041

Merged

This was referenced Mar 22, 2026

publish: getsentry/sentry-dotnet@6.3.0 getsentry/publish#7553

Closed

publish: getsentry/sentry-dotnet@6.3.0 getsentry/publish#7568

Closed

This was referenced Apr 1, 2026

Bump the all group with 3 updates 2FrogsStudio/spin-rally-bot#72

Open

chore: Bump the minor-and-patch group with 13 updates arielbvergara/clean-architecture#64

Open

dependabot bot mentioned this pull request Apr 1, 2026

Bump the all group with 14 updates everscale-actions/eidolonic-bot#119

Open

Uh oh!

Conversation

jamescrosswell commented Feb 23, 2026

Uh oh!

github-actions bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

Breaking Changes 🛠

Fixes 🐛

Dependencies ⬆️

Deps

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Flash0ver left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Feb 23, 2026 •

edited

Loading

codecov bot commented Feb 24, 2026 •

edited

Loading

Flash0ver left a comment •

edited

Loading