test(nuxt): Use sentry.server.config.ts in E2E tests
#13999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 5 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
andreiborza
reviewed
Oct 16, 2024
Comment on lines
4
to
5
| /* This script copies the `import-in-the-middle` content of the E2E test project root `node_modules` to the build output `node_modules` | ||
| For some reason, some files are missing in the output (like `hook.mjs`) and this is not reproducible in external, standalone projects. |
There was a problem hiding this comment.
m: Could we not just use cp inside the build script in package.json instead of writing code to copy this over?
There was a problem hiding this comment.
Changed it, so much cleaner ✨
Thanks for the input!
billyvg
pushed a commit
that referenced
this pull request
Oct 17, 2024
The E2E tests still used an `instrument` file in the `public` folder (which is not the way to setup the SDK anymore) because `import-in-the-middle/hook.mjs` was not available and threw an error. To be able to properly test the setup with `sentry.server.config.ts`, a function was added that copies the `import-in-the-middle` folder to the build output to include all files.
billyvg
pushed a commit
that referenced
this pull request
Oct 17, 2024
The E2E tests still used an `instrument` file in the `public` folder (which is not the way to setup the SDK anymore) because `import-in-the-middle/hook.mjs` was not available and threw an error. To be able to properly test the setup with `sentry.server.config.ts`, a function was added that copies the `import-in-the-middle` folder to the build output to include all files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The E2E tests still used an
instrumentfile in thepublicfolder (which is not the way to setup the SDK anymore) becauseimport-in-the-middle/hook.mjswas not available and threw an error. To be able to properly test the setup withsentry.server.config.ts, a function was added that copies theimport-in-the-middlefolder to the build output to include all files.