-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
test(nuxt): Use sentry.server.config.ts
in E2E tests
#13999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
52 changes: 52 additions & 0 deletions
52
dev-packages/e2e-tests/test-applications/nuxt-3/copyIITM.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
import fs from 'fs'; | ||
import path from 'path'; | ||
|
||
/* This script copies the `import-in-the-middle` content of the E2E test project root `node_modules` to the build output `node_modules` | ||
For some reason, some files are missing in the output (like `hook.mjs`) and this is not reproducible in external, standalone projects. | ||
|
||
Things we tried (that did not fix the problem): | ||
- Adding a resolution for `@vercel/nft` v0.27.0 (this worked in the standalone project) | ||
- Also adding `@vercel/nft` v0.27.0 to pnpm `peerDependencyRules` | ||
*/ | ||
function copyFolderSync(src, dest) { | ||
if (!fs.existsSync(dest)) { | ||
fs.mkdirSync(dest, { recursive: true }); | ||
} | ||
|
||
const entries = fs.readdirSync(src, { withFileTypes: true }); | ||
|
||
for (let entry of entries) { | ||
const srcPath = path.join(src, entry.name); | ||
const destPath = path.join(dest, entry.name); | ||
|
||
if (entry.isDirectory()) { | ||
copyFolderSync(srcPath, destPath); | ||
} else { | ||
fs.copyFileSync(srcPath, destPath); | ||
} | ||
} | ||
} | ||
|
||
function getSourceFolder() { | ||
const specificVersionFolder = `node_modules${path.sep}.pnpm${path.sep}[email protected]${path.sep}node_modules${path.sep}import-in-the-middle`; | ||
|
||
if (fs.existsSync(specificVersionFolder)) { | ||
return specificVersionFolder; | ||
} | ||
|
||
const parentFolder = `node_modules${path.sep}.pnpm`; | ||
const folders = fs.readdirSync(parentFolder, { withFileTypes: true }); | ||
|
||
for (let folder of folders) { | ||
if (folder.isDirectory() && folder.name.startsWith('import-in-the-middle@')) { | ||
return path.join(parentFolder, folder.name, 'node_modules', 'import-in-the-middle'); | ||
} | ||
} | ||
|
||
throw new Error('No suitable import-in-the-middle folder found'); | ||
} | ||
|
||
const sourceFolder = getSourceFolder(); | ||
const destinationFolder = `.output${path.sep}server${path.sep}node_modules${path.sep}import-in-the-middle`; | ||
|
||
copyFolderSync(sourceFolder, destinationFolder); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
52 changes: 52 additions & 0 deletions
52
dev-packages/e2e-tests/test-applications/nuxt-4/copyIITM.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
import fs from 'fs'; | ||
import path from 'path'; | ||
|
||
/* This script copies the `import-in-the-middle` content of the E2E test project root `node_modules` to the build output `node_modules` | ||
For some reason, some files are missing in the output (like `hook.mjs`) and this is not reproducible in external, standalone projects. | ||
|
||
Things we tried (that did not fix the problem): | ||
- Adding a resolution for `@vercel/nft` v0.27.0 (this worked in the standalone project) | ||
- Also adding `@vercel/nft` v0.27.0 to pnpm `peerDependencyRules` | ||
*/ | ||
function copyFolderSync(src, dest) { | ||
if (!fs.existsSync(dest)) { | ||
fs.mkdirSync(dest, { recursive: true }); | ||
} | ||
|
||
const entries = fs.readdirSync(src, { withFileTypes: true }); | ||
|
||
for (let entry of entries) { | ||
const srcPath = path.join(src, entry.name); | ||
const destPath = path.join(dest, entry.name); | ||
|
||
if (entry.isDirectory()) { | ||
copyFolderSync(srcPath, destPath); | ||
} else { | ||
fs.copyFileSync(srcPath, destPath); | ||
} | ||
} | ||
} | ||
|
||
function getSourceFolder() { | ||
const specificVersionFolder = `node_modules${path.sep}.pnpm${path.sep}[email protected]${path.sep}node_modules${path.sep}import-in-the-middle`; | ||
|
||
if (fs.existsSync(specificVersionFolder)) { | ||
return specificVersionFolder; | ||
} | ||
|
||
const parentFolder = `node_modules${path.sep}.pnpm`; | ||
const folders = fs.readdirSync(parentFolder, { withFileTypes: true }); | ||
|
||
for (let folder of folders) { | ||
if (folder.isDirectory() && folder.name.startsWith('import-in-the-middle@')) { | ||
return path.join(parentFolder, folder.name, 'node_modules', 'import-in-the-middle'); | ||
} | ||
} | ||
|
||
throw new Error('No suitable import-in-the-middle folder found'); | ||
} | ||
|
||
const sourceFolder = getSourceFolder(); | ||
const destinationFolder = `.output${path.sep}server${path.sep}node_modules${path.sep}import-in-the-middle`; | ||
|
||
copyFolderSync(sourceFolder, destinationFolder); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
dev-packages/e2e-tests/test-applications/nuxt-4/tests/errors.client.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
dev-packages/e2e-tests/test-applications/nuxt-4/tests/tracing.client.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m: Could we not just use
cp
inside the build script in package.json instead of writing code to copy this over?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it, so much cleaner ✨
Thanks for the input!