Makes busy wait in thread pool optional to prevent unnecessary high cpu loads #2746
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a thread pool with$n > 1$ workers substantially raises the CPU usage. This is mainly due to the worker queue using $n$ cores at 100% load.
std::this_thread::yield
right here.Especially in a nearly idle simulation state (e.g. when pausing in Simulate-like programs), this unnecessarily increases CPU load with
My proposed solution is to introduce an option to toggle busy waiting, which would opt for
std::this_thread::sleep
if disabled. This would retain the option to useyield
instead ofsleep
if speed is more important. Although, I think that sleeping should be the default fit for most use cases.Let me know your thoughts on this