align contact frame to cylinder for sphere-cylinder side collisions #2751
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposed change makes it so that when the side of a cylinder is in contact with a sphere, the contact frame is aligned to the axis of the cylinder. Otherwise, the contact frame seems to have arbitrary alignment because the code simulates a virtual sphere-sphere collision which zeros-out the second axis in the contact frame. The motivation for this change is to make it easier to simulate anisotropic friction on cylinders in contact with spheres. I also opened a discussion about this here, but it is so far unanswered:
Before (inconsistent contact frame alignment):
After (x-axis of contact frame aligned to z-axis of the cylinder):