Skip to content

Add thread-local plugin override functionality (#2727) #2794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add thread-local plugin override functionality (#2727) #2794

wants to merge 2 commits into from

Conversation

ItsVicky25
Copy link

Fixes #2727

Changes

  • Thread-local override system: Added OverrideModeGuard RAII
    class to manage override state
  • Plugin registration override: Modified AppendIfUnique template
    specialization to allow replacing existing plugins when in override
    mode
  • New API functions:
    • mjp_registerPluginWithOverride() - Register plugin with override
      capability
    • mj_loadPluginLibraryEx() - Load plugin library with optional
      override parameter
  • Enhanced return values: Updated mj_loadPluginLibrary() to
    return int status code
  • Memory management: Added proper FreeObject template
    specialization for cleanup

@ItsVicky25
Add thread-local plugin override functionality
7dba4c6
@ItsVicky25
Add thread-local plugin override functionality (google-deepmind#2727)
5bb2a9f 
  Implements plugin override system to address issue google-deepmind#2727:
  - Add thread-local override mode with OverrideModeGuard
  - Allow replacing existing plugins without removing originals
  - Add mjp_registerPluginWithOverride() API function
  - Add mj_loadPluginLibraryEx() with override parameter
  - Update mj_loadPluginLibrary() to return int status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow overriding already registered plugins
1 participant
@ItsVicky25