Avoid memcpy-ing to nullptrs in simulate #2827
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a case in simulate.cc where
std::memcpy
could be invoked with a nullptr as the destination pointer. While the size argument would be zero in these cases, passing a null pointer to memcpy is still undefined behavior according to the C++ standard.The updated logic ensures that memcpy is only called when both the destination pointer is valid and the number of bytes to copy is nonzero. This prevents potential undefined behavior and improves robustness.
Though it is very unlikely that anyone would load a model with
nbody=0
,njnt=0
, and/ornq=0
, I've still added guards for the respective memcpy calls, additionally to the much more realisticneq=0
andnu=0
ones.