Fix MinGW compatibility and Windows-specific crashes#3049
Open
Ashutosh0x wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
Fix MinGW compatibility and Windows-specific crashes#3049Ashutosh0x wants to merge 1 commit intogoogle-deepmind:mainfrom
Ashutosh0x wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
- Fix redefined 'stat' error in MinGW (src/user/user_resource.cc) - Fix MinGW stack flag syntax in MujocoLinkOptions.cmake - Remove stack flags from Python modules to prevent Windows load crashes - Enable thread-safe localtime_s for MinGW (src/engine/engine_util_errmem.c) - Handle 0-sized mju_malloc on Windows to prevent crashes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description: Fix MinGW Compatibility and Windows-Specific Crashes
This Pull Request addresses several critical issues discovered in the MuJoCo physics engine, specifically regarding Windows build stability and runtime robustness when using MinGW or Python.
Issues Fixed
1. MinGW 'stat' Redefinition (#3038)
2. MinGW Stack Flag Syntax (#3011)
3. Python Binding Crashes (#3011)
4. Thread-safe 'localtime' for MinGW (#3037)
5. Zero-sized Allocation Crash (#2992)
Verification
These changes significantly improve the accessibility of MuJoCo for developers on Windows using open-source toolchains.