Fix MinGW build: Replace unsupported %zu format with %llu#3059
Open
ayaz2004 wants to merge 2 commits intogoogle-deepmind:mainfrom
Open
Fix MinGW build: Replace unsupported %zu format with %llu#3059ayaz2004 wants to merge 2 commits intogoogle-deepmind:mainfrom
ayaz2004 wants to merge 2 commits intogoogle-deepmind:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ayaz2004
force-pushed
the
fix-mingw-format-specifier
branch
from
26c410d to
f57971b
Compare
2 tasks
maximilian-maisel-bl
suggested changes
Jan 29, 2026
maximilian-maisel-bl
left a comment
maximilian-maisel-bl
left a comment
There was a problem hiding this comment.
I tested on Linux and Windows with gcc and the testspeed sample.
|
Looks good to me now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This PR fixes a compilation error when building with MinGW-w64. The compiler treats %zu as an unknown format specifier because it defaults to checking against MSVCRT compatibility, where %z is not supported in older runtimes.
Bug: When compiling src/thread/thread_pool.cc with MinGW, the following error occurs:
src/thread/thread_pool.cc:202:47: error: unknown conversion type character ‘z’ in format [-Werror=format=]
mju_error("Arena is not large enough for %zu shards", number_of_shards);
Fix: Replaced %zu with %llu and cast the corresponding arguments to unsigned long long. This ensures the format string is valid across all platforms (Windows/MinGW, MSVC, Linux, macOS) without relying on C99 runtime support for %z.
Verification: I have verified that this change fixes the build error on a Windows 11 machine using the MinGW64 toolchain.