Fix Windows DLL Export for Callback Globals#3062
Open
Adityakk9031 wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
Fix Windows DLL Export for Callback Globals#3062Adityakk9031 wants to merge 1 commit intogoogle-deepmind:mainfrom
Adityakk9031 wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
Author
|
@btaba please check this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes.#3060
Issue
On Windows with non-MSVC compilers (e.g., Rust with MinGW), MuJoCo callback symbols (mju_user_* and mjcb_*) fail to link. The import library only contains _imp symbols, not direct symbols, causing link errors like:
error LNK2019: unresolved external symbol mju_user_error referenced in function...
Root Cause
Windows __declspec(dllimport/dllexport) treats global variables differently from functions:
Functions: Creates both direct symbol AND _imp entry
Global Variables: Only creates _imp entry in import library
Non-MSVC linkers expect direct symbols and fail when they're missing.
Solution
Added getter/setter accessor functions for all callback globals. Functions export correctly on Windows because __declspec creates proper linkable symbols for them.