fix(user_init): use memcpy for gridlayout initialization#3069
Open
j-rivero wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
fix(user_init): use memcpy for gridlayout initialization#3069j-rivero wants to merge 1 commit intogoogle-deepmind:mainfrom
j-rivero wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
Replace strncpy with memcpy for initializing texture->gridlayout. The gridlayout field is a fixed 12-byte array that is not null-terminated, so using string functions is semantically incorrect. memcpy explicitly copies exactly sizeof(gridlayout) bytes, which: - Correctly reflects that gridlayout is binary data, not a C string - Removes the unnecessary local variable Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello:
I think that I found a probem with the gridlayout size in the user_init file. The gridlayout field is a fixed 12-byte array that is not null-terminated, so using string functions is semantically incorrect. memcpy explicitly copies exactly sizeof(gridlayout) bytes, which:
Note that this triggered an error in the build after adding a workaround for #2904: