Fix zero-size malloc and memcpy#3081
Open
rdeits-bd wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
quagla
requested changes
Feb 11, 2026
Contributor
quagla
left a comment
There was a problem hiding this comment.
Thanks for the change! A small remark, can you please move the comments from inside the if to the start of the blocks that you changed?
Author
|
Happy to make that change. I'm currently blocked waiting for our lawyers to approve your CLA. If you'd rather just make the relevant commit yourself that's of course fine by me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running some our internal code under
valgrind, I ran into warnings inside Mujoco'sset0function:I can reproduce this by running the
simulatebinary after building from source:The issue is that
m->nflexcan be zero, in which case we end up callingaligned_allocwith a size of zero. I can't find clear information on whether that's allowed or not -- some sources say yes, others say no. Thememcpyon the subsequent line is also suspect: Ifmallocreturns null (which I think it's allowed to for zero size), then even a zero-sizememcpyis undefined behavior with a null destination.This change resolves the valgrind warning in
set0. Note that we do still see some warnings insidelibnvidia-glcoreboth before and after this change.