full change in implementing windows malloc support#3170
Open
mar-yan24 wants to merge 2 commits intogoogle-deepmind:mainfrom
Open
full change in implementing windows malloc support#3170mar-yan24 wants to merge 2 commits intogoogle-deepmind:mainfrom
mar-yan24 wants to merge 2 commits intogoogle-deepmind:mainfrom
Conversation
Contributor
Author
|
the more i work on this solution the more im confused on whether or not it is optimal, just implemented a quick fix to pass one of the test cases. any suggestions would be great |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary -
Fixes #2337: Windows memory allocation failure when creating many MjData instances.
Not sure if there is much interest in still resolving this issue by @okmatija or @yuvaltassa but I did a simple edit on the original MRE to print the memory allocation and discovered that the origin of the issue. In
engine_io.cthreemju_malloccalls are made for eachMjDatausing aligned malloc so its overloading the VMS.Before:

After:

Fix
For allocations >= 64KB on windows, I just replaced
_aligned_mallocwithVirtualAlloc(MEM_RESERVE)and a vectored exception handler that commits pages on first access. This basically just mimics the linux overcommit behavior.I am pretty confident that this implementation is safe but a review or some help with the code implementation if needed would be nice.