Fix Filament crash when hiding geom groups - #3543
Open
nico-bohlinger wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
I ran into a repeatable Studio crash with the Filament renderer when toggling a geom group visibility. The program terminated with an uncaught
utils::PreconditionPanic.When a geom group was hidden, its renderables were removed from the scene and no longer prepared for the next frame. Their material instances therefore appeared unused and were destroyed, even though the hidden entities still referenced them. Filament rejected that destruction and aborted.
I simply reset the renderable to Filament's default material before removing it from the scene. I also initialized the cached material key and added a test that renders a geom, hides its group, renders again, and then shows it again.