Upgrade to Java 11 and to Metafacture 7.0.0 #455

[TobiasNx]

@fsteeg not sure if this is a quick adjustment? but the tests seem to work fine I reproduced the way we use java 11 in context of lobid-organisations and build upon @Phu2 PR #456

This is not urgent, but maybe helpful.

Resolve #455

[fsteeg]

@fsteeg not sure if this is a quick adjustment? but the tests seem to work fine

I don't think so, the app doesn't run for me. I think we need to at least update scalaVersion, javacOptions, and sbt.version (but probably more), see hbz/rpb@0b59e22#diff-5634c415cd8c8504fdb973a3ed092300b43c4b8fc1e184f7249eb29a55511f91

[TobiasNx]

sbt run works if you use the weywots instead of the localhost index. FYI @fsteeg

[fsteeg]

Same as in hbz/nwbib#679, I think we should stick with our process and do a separate functional review (e.g. by @acka47) before code review.

[acka47]

I am happy to make a functional review, however, I am refraining from this for now as this is still a draft PR and the issue was not assigned to me.

[TobiasNx]

The reintroduces sbt clean and sbt stage that @Phu2 dropped before: d7d693f

[fsteeg]

Like I said, both is fine here, lobid-gnd doesn't log to target.

[TobiasNx]

@Phu2 you can deploy and merge

[Phu2]

Why do we add internal server adresses here? I don't think we should publish them.

[TobiasNx]

@fsteeg could you help here?

[fsteeg]

Since these are commented out anyway, you could remove them here. The idea would be to have an internal Wiki page for the details, like we have for RPB.

[Phu2]

Trying to deploy this branch on test, monit (re)starts the app several times without success. From monit.log:

[2026-02-23T10:29:14+0100] error    : 'lobid-gnd' process is not running
[2026-02-23T10:29:14+0100] info     : 'lobid-gnd' trying to restart
[2026-02-23T10:29:14+0100] info     : 'lobid-gnd' start: '/home/sol/git/lobid-gnd/monit_restart.sh lobid-gnd start 7100'
[2026-02-23T10:29:45+0100] error    : 'lobid-gnd' failed to start (exit status 0) -- '/home/sol/git/lobid-gnd/monit_restart.sh lobid-gnd start 7100': WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by sbt.ivyint.ErrorMessageAuthenticator$ (file:/home/sol/.sbt/boot/scala-2.10.7/org.scala-sbt/sbt/0.13.18/ivy.jar) to field java.net.Authenticator.theAuthentic
[2026-02-23T10:31:05+0100] error    : 'lobid-gnd' process is not running
[2026-02-23T10:31:05+0100] info     : 'lobid-gnd' trying to restart
[2026-02-23T10:31:05+0100] info     : 'lobid-gnd' start: '/home/sol/git/lobid-gnd/monit_restart.sh lobid-gnd start 7100'
[2026-02-23T10:31:35+0100] error    : 'lobid-gnd' failed to start (exit status 0) -- '/home/sol/git/lobid-gnd/monit_restart.sh lobid-gnd start 7100': WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by sbt.ivyint.ErrorMessageAuthenticator$ (file:/home/sol/.sbt/boot/scala-2.10.7/org.scala-sbt/sbt/0.13.18/ivy.jar) to field java.net.Authenticator.theAuthentic
[2026-02-23T10:32:55+0100] error    : 'lobid-gnd' process is not running
[2026-02-23T10:32:55+0100] info     : 'lobid-gnd' trying to restart
[2026-02-23T10:32:55+0100] info     : 'lobid-gnd' start: '/home/sol/git/lobid-gnd/monit_restart.sh lobid-gnd start 7100'
[2026-02-23T10:33:26+0100] error    : 'lobid-gnd' failed to start (exit status 0) -- '/home/sol/git/lobid-gnd/monit_restart.sh lobid-gnd start 7100': WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by sbt.ivyint.ErrorMessageAuthenticator$ (file:/home/sol/.sbt/boot/scala-2.10.7/org.scala-sbt/sbt/0.13.18/ivy.jar) to field java.net.Authenticator.theAuthentic

@TobiasNx @fsteeg I have no clue why it won't start.

[fsteeg]

@TobiasNx @fsteeg I have no clue why it won't start.

On q13? From logs/application.log (that's where you'd see errors from the app during startup too) it seems it started successfully at 10:45, but with Java 8. Did you roll it back there? Or are you testing elsewhere?

[Phu2]

On q13? From logs/application.log (that's where you'd see errors from the app during startup too) it seems it started successfully at 10:45, but with Java 8. Did you roll it back there? Or are you testing elsewhere?

Yes, on q13. I did a rollback in between.

[fsteeg]

The problem was the missing -no-version-check when starting the app in monit_restart.sh (see inline comment above). I probably forgot that I added it locally when testing this during initial review. Now running on Java 11 on https://test.lobid.org/gnd (In our regular process, only now would have been the point to start functional review, not sure how to handle that in this case, probably not needed to do another round with @acka47?).

From logs/application.log (that's where you'd see errors from the app during startup too)

That doesn't seem to be true (any longer?), since I saw nothing there during attempted startup without -no-version-check. Not sure if this is changed behavior due to our recent changes in the startup scripts or if this would have been the same before.

When manually running /target/universal/stage/bin/lobid-gnd -Dhttp.port=7100 (what monit_restart.sh calls) I got:

The java installation you have is not up to date
requires at least version 1.6+, you have
version 11.0.30

That provided the clue to the missing -no-version-check (which we originally figured out in hbz/lobid-resources#1965 (comment)).

[acka47]

I quickly did some functional review and things are looking fine to me. +1

(I only noticed one thing: The manifest URL in https://test.lobid.org/gnd/reconcile/ is not correct. It should be https://test.lobid.org/gnd/reconcile/ instead of https://reconcile-gnd-test.lobid.org but I guess it has been like this for a long time.)