Skip to content

Quick test to update to java 11#679

Merged
fsteeg merged 6 commits intomasterfrom
6645-updateJavaVersionTo11
Mar 5, 2026
Merged

Quick test to update to java 11#679
fsteeg merged 6 commits intomasterfrom
6645-updateJavaVersionTo11

Conversation

@TobiasNx
Copy link
Contributor

@TobiasNx TobiasNx commented Feb 18, 2026

Quick test with regard to updating the java version to 11

Related to #665

Maybe it needs some adjustments inspired by https://github.com/hbz/rpb/pull/130/changes#diff-75ff37996f3bf481e0e9b6566d5cd9eec8c4a09a75e76a6470edcec1c9e0142dR28

@TobiasNx TobiasNx force-pushed the 6645-updateJavaVersionTo11 branch from b27ca26 to 877614d Compare February 18, 2026 10:01
@TobiasNx
Copy link
Contributor Author

TobiasNx commented Feb 18, 2026

Copied some more stuff from the rpb java update, now the tests result in the following as before:

[info] Passed: Total 27, Failed 0, Errors 0, Passed 25, Skipped 2
[success] Total time: 169 s, completed Feb 18, 2026, 10:43:34 AM

@fsteeg maybe this could be a fix adjustment, but this is not urgent.

@fsteeg
Copy link
Member

fsteeg commented Feb 18, 2026

@fsteeg maybe this could be a fix adjustment, but this is not urgent.

Doesn't work for me (sbt run), same as in hbz/lobid-gnd#459 (comment).

@TobiasNx TobiasNx force-pushed the 6645-updateJavaVersionTo11 branch from 1c5c4d0 to 5ec32c7 Compare February 18, 2026 12:48
@TobiasNx
Copy link
Contributor Author

@fsteeg sbt run is not working under java 11, instead use:

  • sbt clean
  • sbt stage
  • ./target/universal/stage/bin/nwbib -no-version-check

This works for me

@fsteeg
Copy link
Member

fsteeg commented Feb 18, 2026

@fsteeg sbt run is not working under java 11, instead use: [...]

It's sbt start that doesn't run on Java 11 and has been replaced with stage in our Java 11 apps. sbt run works in e.g. rpb (and is needed for development). Also, this PR is still marked as draft.

@fsteeg fsteeg removed their request for review February 18, 2026 13:09
@fsteeg fsteeg removed their assignment Feb 18, 2026
@TobiasNx TobiasNx marked this pull request as ready for review February 18, 2026 13:33
@TobiasNx
Copy link
Contributor Author

@fsteeg sbt run is not working under java 11, instead use: [...]

It's sbt start that doesn't run on Java 11 and has been replaced with stage in our Java 11 apps. sbt run works in e.g. rpb (and is needed for development). Also, this PR is still marked as draft.

Okay, that is new to me, in context of lobid-organisations and -resources, the build of the web app is not done with sbt run anymore. So I thought that the steps above would be sufficient.

@TobiasNx
Copy link
Contributor Author

sbt run also works!

@fsteeg
Copy link
Member

fsteeg commented Feb 19, 2026

I think we should stick with our process and do a separate functional review (e.g. by @acka47) before code review.

@fsteeg fsteeg removed their assignment Feb 19, 2026
@fsteeg fsteeg removed their request for review February 19, 2026 09:32
@acka47 acka47 linked an issue Feb 19, 2026 that may be closed by this pull request
@acka47 acka47 requested a review from fsteeg February 19, 2026 13:39
@fsteeg
Copy link
Member

fsteeg commented Feb 19, 2026

It seems functional review is not complete, see #665 (comment).

@fsteeg fsteeg removed their request for review February 19, 2026 14:34
@fsteeg fsteeg removed their assignment Feb 19, 2026
@acka47
Copy link
Contributor

acka47 commented Feb 19, 2026

It seems functional review is not complete, see #665 (comment).

It is, see #665 (comment)

@acka47 acka47 requested a review from fsteeg February 19, 2026 14:49
@fsteeg
Copy link
Member

fsteeg commented Feb 20, 2026

Ah, I see, I had to delete the old local embedded Elasticsearch index to make it work (rm -rf data/elasticsearch/*).

@fsteeg fsteeg assigned TobiasNx and unassigned fsteeg Feb 20, 2026
@TobiasNx
Copy link
Contributor Author

@Phu2 can you deploy and merge?

@TobiasNx TobiasNx assigned Phu2 and unassigned TobiasNx Feb 20, 2026
@Phu2 Phu2 assigned TobiasNx and Phu2 and unassigned Phu2 and TobiasNx Feb 24, 2026
@Phu2
Copy link

Phu2 commented Feb 24, 2026

I tried to deploy on test (q13):

  • stash local changes
  • switch to this branch
  • stash pop local changes
  • sh restart.sh nwbib

errors shown up in target/universal/stage/logs/application.log. Please have a look.

15:29:24,245 |-ERROR in ch.qos.logback.core.rolling.RollingFileAppender[FILE] - Failed to create parent directories for [/home/sol/git/nwbib/target/universal/stage/application.home_IS_UNDEFINED/logs/application.log]
15:29:24,245 |-ERROR in ch.qos.logback.core.rolling.RollingFileAppender[FILE] - openFile(application.home_IS_UNDEFINED/logs/application.log,true) call failed. java.io.FileNotFoundException: application.home_IS_UNDEFINED/logs/application.log (Datei oder Verzeichnis nicht gefunden)
        at java.io.FileNotFoundException: application.home_IS_UNDEFINED/logs/application.log (Datei oder Verzeichnis nicht gefunden)
        at      at java.base/java.io.FileOutputStream.open0(Native Method)
        at      at java.base/java.io.FileOutputStream.open(FileOutputStream.java:298)
        at      at java.base/java.io.FileOutputStream.<init>(FileOutputStream.java:237)
        at      at ch.qos.logback.core.recovery.ResilientFileOutputStream.<init>(ResilientFileOutputStream.java:28)
        at      at ch.qos.logback.core.FileAppender.openFile(FileAppender.java:148)
        at      at ch.qos.logback.core.FileAppender.start(FileAppender.java:108)
        at      at ch.qos.logback.core.rolling.RollingFileAppender.start(RollingFileAppender.java:86)
        at      at ch.qos.logback.core.joran.action.AppenderAction.end(AppenderAction.java:96)
        at      at ch.qos.logback.core.joran.spi.Interpreter.callEndAction(Interpreter.java:317)
        at      at ch.qos.logback.core.joran.spi.Interpreter.endElement(Interpreter.java:196)
        at      at ch.qos.logback.core.joran.spi.Interpreter.endElement(Interpreter.java:182)
        at      at ch.qos.logback.core.joran.spi.EventPlayer.play(EventPlayer.java:62)
        at      at ch.qos.logback.core.joran.GenericConfigurator.doConfigure(GenericConfigurator.java:149)
        at      at ch.qos.logback.core.joran.GenericConfigurator.doConfigure(GenericConfigurator.java:135)
        at      at ch.qos.logback.core.joran.GenericConfigurator.doConfigure(GenericConfigurator.java:99)
        at      at ch.qos.logback.core.joran.GenericConfigurator.doConfigure(GenericConfigurator.java:49)
        at      at ch.qos.logback.classic.util.ContextInitializer.configureByResource(ContextInitializer.java:77)
        at      at ch.qos.logback.classic.util.ContextInitializer.autoConfig(ContextInitializer.java:152)
        at      at org.slf4j.impl.StaticLoggerBinder.init(StaticLoggerBinder.java:85)
        at      at org.slf4j.impl.StaticLoggerBinder.<clinit>(StaticLoggerBinder.java:55)
        at      at org.slf4j.LoggerFactory.bind(LoggerFactory.java:150)
        at      at org.slf4j.LoggerFactory.performInitialization(LoggerFactory.java:124)
        at      at org.slf4j.LoggerFactory.getILoggerFactory(LoggerFactory.java:417)
        at      at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:362)
        at      at play.api.Logger$.<init>(Logger.scala:177)
        at      at play.api.Logger$.<clinit>(Logger.scala)
        at      at play.api.inject.guice.GuiceApplicationBuilder.applicationModule(GuiceApplicationBuilder.scala:78)
        at      at play.api.inject.guice.GuiceBuilder.injector(GuiceInjectorBuilder.scala:126)
        at      at play.api.inject.guice.GuiceApplicationBuilder.build(GuiceApplicationBuilder.scala:98)
        at      at play.api.inject.guice.GuiceApplicationLoader.load(GuiceApplicationLoader.scala:21)
        at      at play.core.server.ProdServerStart$.start(ProdServerStart.scala:52)
        at      at play.core.server.ProdServerStart$.main(ProdServerStart.scala:27)
        at      at play.core.server.ProdServerStart.main(ProdServerStart.scala)

@Phu2 Phu2 assigned fsteeg and unassigned Phu2 Feb 24, 2026
@Phu2
Copy link

Phu2 commented Feb 24, 2026

I'll do a rollback for now to bring up the test instance again.

@TobiasNx
Copy link
Contributor Author

TobiasNx commented Mar 4, 2026

@fsteeg can you help, I am not sure how to solve this.

@fsteeg
Copy link
Member

fsteeg commented Mar 5, 2026

Needed to rebuild the embedded Elasticsearch index (triggered by deleting the old), started with:

rm -rf target/universal/stage/data/elasticsearch/; sh restart.sh nwbib ; tail -f target/universal/stage/logs/application.log

Hint was this in the logs:

java.lang.IllegalStateException: unsupported compression: index was created before v2.0.0.beta1 and wasn't upgraded?

Now running on test: https://test.nwbib.de/

Will deploy to production and merge.

@fsteeg fsteeg merged commit 4a59071 into master Mar 5, 2026
1 check passed
@fsteeg fsteeg deleted the 6645-updateJavaVersionTo11 branch March 5, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Java version zu 11

5 participants