Skip to content

Conversation

@ParagEkbote
Copy link
Contributor

What does this PR do?

As discussed in this PR: huggingface/diffusers#9905 , I have added the notebooks under the diffusers folder. After this PR gets merged, I will update the Colab column in the ReadMe.

Please let me know if any improvements are needed and I will make the necessary changes.

Who can review?

cc:@stevhliu

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you also rename the files to the following?

asymmetric_tiling
prompt_scheduling_callback
ip_adapter_negative_noise

@ParagEkbote
Copy link
Contributor Author

ParagEkbote commented Nov 12, 2024

I have updated the notebooks as per the given feedback.

Could you please review?

cc: @stevhliu

@ParagEkbote ParagEkbote requested a review from stevhliu November 12, 2024 14:48
@stevhliu
Copy link
Member

stevhliu commented Nov 12, 2024

Still need to change the notebook name prompt_saving_callback to prompt_scheduling_callback

@ParagEkbote
Copy link
Contributor Author

Sorry for the oversight. I have renamed the notebook.

Could you please review?

cc: @stevhliu

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

@stevhliu stevhliu merged commit 27a63b8 into huggingface:main Nov 12, 2024
@ParagEkbote ParagEkbote deleted the notebooks-for-diffusers branch November 12, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants