Skip to content

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jan 29, 2025

@m7pr m7pr requested review from a team and pawelru January 29, 2025 15:33
Copy link
Contributor

@cicdguy cicdguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025

Unit Tests Summary

3 tests   2 ✅  4s ⏱️
3 suites  1 💤
1 files    0 ❌

Results for commit 47dc57f.

♻️ This comment has been updated with latest results.

@pawelru
Copy link
Contributor

pawelru commented Jan 29, 2025

These are good changes but not complete as of now.
Also - this can be merged only if Remotes is added in all (!) the repos. Please note that!

@m7pr
Copy link
Contributor Author

m7pr commented Jan 29, 2025

I'll be testing with this teal PR insightsengineering/teal#1466
but will first check your comments and advices

@m7pr
Copy link
Contributor Author

m7pr commented Jan 29, 2025

@pawelru

if Remotes is added in all (!) the repos.

by all, how many we are talking about? all in https://github.com/insightsengineering org?

@pawelru pawelru marked this pull request as draft January 29, 2025 15:44
@pawelru
Copy link
Contributor

pawelru commented Jan 29, 2025

@pawelru

if Remotes is added in all (!) the repos.

by all, how many we are talking about? all in https://github.com/insightsengineering org?

All where necessary. Obviously these live in our org and include also tern and family etc.

@m7pr
Copy link
Contributor Author

m7pr commented Jan 29, 2025

@pawelru so far I adjusted possible inputs that are passed to r-lib/actions/setup-r-dependencies@v2 and removed those inputs from example teal PR insightsengineering/teal#1466

@m7pr m7pr requested a review from cicdguy January 30, 2025 08:07
@m7pr m7pr marked this pull request as ready for review January 30, 2025 08:07
Copy link
Contributor

@pawelru pawelru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good one and I'm ok with that but please note that it's a breaking change for all the packages that are still using lookup-refs parameter! Hence not approving formally but just saying it's good but others are not ready.

@m7pr
Copy link
Contributor Author

m7pr commented Feb 6, 2025

A test PR in teal insightsengineering/teal#1484 that runs checks via this PR

@pawelru
Copy link
Contributor

pawelru commented Feb 11, 2025

OK. This is good to go. Please make sure that all (!) the upstream packages follows - in particular: they might be passing parameters that you are about to remove! This most likely would fail the jobs.

@m7pr
Copy link
Contributor Author

m7pr commented Feb 11, 2025

For now it runs smoothly in the PR created in teal to test that insightsengineering/teal#1484

I also created a card to track down all other packages insightsengineering/nestdevs-tasks#103

run-system-dependencies: ${{ inputs.install-system-dependencies }}
direction: ${{ inputs.sd-direction }}

- name: Setup R dependencies 🎦
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a comment, so it can not be merged.
It should not be merged before other packages are not suited for changes introduced in this PR.
Other packages are tracked in this card insightsengineering/nestdevs-tasks#103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants