-
-
Notifications
You must be signed in to change notification settings - Fork 19
wip: fix e2e test on tm_g_pp functions #1446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have read the CLA Document and I hereby sign the CLA 2 out of 3 committers have signed the CLA. |
|
I have read the CLA Document and I hereby sign the CLA |
| app_driver$stop() | ||
| }) | ||
|
|
||
| #fails |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try adding app_driver$wait_for_idle() after app_driver <- app_driver_tm_g_pp_vitals().
And also check how I fixed similar tests on the feature branch
https://github.com/insightsengineering/teal.modules.clinical/pull/1441/files#r2565145226
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this was updated and it works, after trying the new teal version
Unit Tests Summary 1 files ± 0 71 suites ±0 2h 19m 59s ⏱️ + 2h 18m 37s For more details on these failures and errors, see this check. Results for commit 4f93677. ± Comparison against base commit d200e5f. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceTest suite performance difference
Additional test case details
Results for commit 789aa83 ♻️ This comment has been updated with latest results. |
Fix e2e tests
Fixes #1440
Companion #1441
To verify the result of tests, you should do the following: