Skip to content

Conversation

@osenan
Copy link

@osenan osenan commented Nov 25, 2025

Fix e2e tests

Fixes #1440
Companion #1441

To verify the result of tests, you should do the following:

  1. Install this branch of teal
  2. Install teal modules clinical on this version
devtools::load_all()
library(shinytest2)
source("tests/testthat/helper-TealAppDriver.R")
source("tests/testthat/helper-testing-depth.R")
testthat::test_file("tests/testthat/test-shinytest2-tm_g_pp_patient_timeline.R")
testthat::test_file("tests/testthat/test-shinytest2-tm_g_pp_vitals.R")
testthat::test_file("tests/testthat/test-shinytest2-tm_g_pp_therapy.R")
testthat::test_file("tests/testthat/test-shinytest2-tm_g_pp_adverse_events.R")

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025


🎉 Thank you for your contribution! Before this PR can be accepted, we require that you all read and agree to our Contributor License Agreement.
You can digitally sign the CLA by posting a comment on this Pull Request in the format shown below. This agreement will apply to this PR as well as all future contributions on this repository.


I have read the CLA Document and I hereby sign the CLA


2 out of 3 committers have signed the CLA.
✅ (llrs-roche)[https://github.com/llrs-roche]
✅ (m7pr)[https://github.com/m7pr]
@osenan
osenan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@osenan osenan changed the title wip: fix some tests by changing selectors in vitals wip: fix e2e test on tm_g_pp functions Nov 26, 2025
@osenan
Copy link
Author

osenan commented Nov 26, 2025

I have read the CLA Document and I hereby sign the CLA

app_driver$stop()
})

#fails
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try adding app_driver$wait_for_idle() after app_driver <- app_driver_tm_g_pp_vitals().
And also check how I fixed similar tests on the feature branch
https://github.com/insightsengineering/teal.modules.clinical/pull/1441/files#r2565145226

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this was updated and it works, after trying the new teal version

@osenan osenan marked this pull request as ready for review November 26, 2025 18:49
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

Unit Tests Summary

    1 files  ±    0     71 suites  ±0   2h 19m 59s ⏱️ + 2h 18m 37s
  734 tests ±    0    407 ✅ +  252  117 💤  - 462  185 ❌ +185  25 🔥 +25 
1 940 runs  +1 066  1 475 ✅ +1 299  117 💤  - 581  323 ❌ +323  25 🔥 +25 

For more details on these failures and errors, see this check.

Results for commit 4f93677. ± Comparison against base commit d200e5f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_gee 💔 $0.23$ $+3.52$ $0$ $0$ $0$ $0$
shinytest2-tm_a_mmrm 💔 $0.66$ $+7.57$ $0$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 💔 $0.33$ $+2.64$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ci 💔 $0.20$ $+1.17$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 💔 $0.25$ $+2.62$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ipp 💔 $0.19$ $+2.75$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💔 $0.38$ $+3.07$ $0$ $0$ $0$ $0$
shinytest2-tm_g_lineplot 💔 $0.14$ $+1.14$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_adverse_events 💔 $0.25$ $+1.85$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_patient_timeline 💔 $0.37$ $+4.69$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_therapy 💔 $0.33$ $+7.10$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_vitals 💔 $0.16$ $+1.21$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality 💔 $0.13$ $+1.11$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality_by_worst_grade 💔 $0.12$ $+1.31$ $0$ $0$ $0$ $0$
shinytest2-tm_t_ancova 💔 $0.37$ $+1.97$ $0$ $0$ $0$ $0$
shinytest2-tm_t_binary_outcome 💔 $0.14$ $+1.36$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_by_grade 💔 $0.13$ $+1.46$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_summary 💔 $0.11$ $+2.40$ $0$ $0$ $0$ $0$
shinytest2-tm_t_exposure 💔 $0.13$ $+3.04$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_laboratory 💔 $0.22$ $+1.45$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_prior_medication 💔 $0.16$ $+1.50$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm 💔 $0.11$ $+1.28$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm_by_worst 💔 $0.17$ $+1.88$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_grade 💔 $0.13$ $+1.86$ $0$ $0$ $0$ $0$
shinytest2-tm_t_smq 💔 $0.11$ $+1.25$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary_by 💔 $0.15$ $+1.49$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_g_km 💀 $0.01$ $-0.01$ e2e_tm_g_km_Starts_with_specified_collapsed_additional_plot_settings.
shinytest2-tm_g_km 👶 $+0.13$ e2e_tm_g_km_Starts_with_uncollapsed_additional_plot_settings.

Results for commit 789aa83

♻️ This comment has been updated with latest results.

@m7pr m7pr merged commit 1a74548 into bring_tests Nov 27, 2025
11 of 20 checks passed
@m7pr m7pr deleted the fix_e2e_g_pp@bring_tests branch November 27, 2025 09:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants