Skip to content

Conversation

@vedhav
Copy link
Contributor

@vedhav vedhav commented Apr 1, 2025

Closes #870

Here are the steps to be done with this PR:

  • Review the changes of this branch with the release version of the packages
  • Release the hot fix on CRAN
  • Merge main back to this 870-hotfix@to-cran branch
  • Resolve the version conflict manually and use 0.4.1.9000
  • Merge it to main by skipping the vbump

@vedhav vedhav added the core label Apr 1, 2025
@vedhav vedhav changed the title [skip vbump] [Hot fix] upversion v0.4.1 [skip vbump] [skip actions] Hot fix - upversion v0.4.1 Apr 1, 2025
@llrs-roche llrs-roche self-assigned this Apr 1, 2025
Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran all the 8 first examples of the modules. All of them ran well and the filter updated the plot and tables.

tm_a_pca ✅

Plot and Principal components importance change but igenvectors remains constant (as expected for 2 variables). When multiple variables are included the igenvectors' table is also updated.
https://github.com/user-attachments/assets/342e97c6-b9c4-435d-821f-5a735b93fbf4

tm_a_regression ✅
tm_a_regression.mp4
tm_g_association ✅
tm_g_association.mp4
tm_g_bivariate✅
tm_g_bivariate.mp4
tm_g_distribution✅
tm_g_distribution.mp4
tm_g_response✅
tm_g_response.mp4
tm_g_scatterplot✅
tm_g_scatterplot.mp4
tm_t_crosstable✅
tm_t_crosstable.mp4

One minor comment if the updated code is a reactive, should it also be under req(..., qenv())? It might help wit the reactivity graph to ensure that it is there (not that I expect it to be missing but I thought it is a good practice).

I tested this with R 4.4.3 and the latest versions of all packages:

SessionInfo

R version 4.4.3 (2025-02-28 ucrt)
Platform: x86_64-w64-mingw32/x64
Running under: Windows 11 x64 (build 22631)

Matrix products: default


locale:
[1] LC_COLLATE=Spanish_Spain.utf8  LC_CTYPE=Spanish_Spain.utf8    LC_MONETARY=Spanish_Spain.utf8 LC_NUMERIC=C                   LC_TIME=Spanish_Spain.utf8    

time zone: Europe/Madrid
tzcode source: internal

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
 [1] tern_0.9.7                 rtables_0.6.11             magrittr_2.0.3             formatters_0.5.10.9000     tidyr_1.3.1                dplyr_1.1.4               
 [7] nestcolor_0.1.3            teal.modules.general_0.4.1 testthat_3.2.3             teal.transform_0.6.0       teal_0.16.0                teal.slice_0.6.0          
[13] teal.data_0.7.0            teal.code_0.6.1            shiny_1.10.0               ggmosaic_0.3.3             ggplot2_3.5.1              pkgdown_2.1.1.9000        
[19] devtools_2.4.5             usethis_3.1.0             

loaded via a namespace (and not attached):
  [1] sys_3.4.3             rstudioapi_0.17.1     jsonlite_2.0.0        farver_2.1.2          rmarkdown_2.29        ragg_1.3.3            fs_1.6.5              vctrs_0.6.5          
  [9] memoise_2.0.1         askpass_1.2.1         gh_1.4.1              htmltools_0.5.8.1     forcats_1.0.0         polynom_1.4-1         curl_6.2.2            broom_1.0.8          
 [17] sass_0.4.9            bslib_0.9.0           htmlwidgets_1.6.4     desc_1.4.3            fontawesome_0.5.3     plyr_1.8.9            httr2_1.1.2           plotly_4.10.4        
 [25] cachem_1.1.0          mime_0.12             lifecycle_1.0.4       teal.widgets_0.4.3    pkgconfig_2.0.3       colourpicker_1.3.0    Matrix_1.7-3          R6_2.6.1             
 [33] fastmap_1.2.0         rbibutils_2.3         digest_0.6.37         colorspace_2.1-1      shinycssloaders_1.1.0 rprojroot_2.0.4       shinyTree_0.3.1       pkgload_1.4.0        
 [41] crosstalk_1.2.1       textshaping_1.0.0     productplots_0.1.1    labeling_0.4.3        mgcv_1.9-1            httr_1.4.7            compiler_4.4.3        sparkline_2.0        
 [49] remotes_2.5.0         withr_3.0.2           backports_1.5.0       logger_0.4.0          pkgbuild_1.4.7        MASS_7.3-65           quantreg_6.1          openssl_2.3.2        
 [57] rappdirs_0.3.3        sessioninfo_1.2.3     ggpp_0.5.8-1          tools_4.4.3           httpuv_1.6.15         shinyvalidate_0.1.3   goftest_1.2-3         glue_1.8.0           
 [65] nlme_3.1-167          promises_1.3.2        grid_4.4.3            checkmate_2.3.2       generics_0.1.3        gtable_0.3.6          data.table_1.17.0     ggrepel_0.9.6        
 [73] pillar_1.10.1         stringr_1.5.1         ggExtra_0.10.1        later_1.4.1           splines_4.4.3         lattice_0.22-6        renv_1.1.4            survival_3.8-3       
 [81] SparseM_1.84-2        tidyselect_1.2.1      miniUI_0.1.1.1        knitr_1.50            ggpmisc_0.6.1         gitcreds_0.1.2        gridExtra_2.3         teal.logger_0.3.2    
 [89] xfun_0.51             credentials_2.0.2     brio_1.1.5            DT_0.33               stringi_1.8.7         lazyeval_0.2.2        yaml_2.3.10           shinyWidgets_0.9.0   
 [97] evaluate_1.0.3        tibble_3.2.1          cli_3.6.4             systemfonts_1.2.1    
 [ reached getOption("max.print") -- omitted 21 entries ]

@vedhav vedhav force-pushed the 870-hot-fix@to-cran branch from 35008ba to 028e966 Compare April 1, 2025 14:31
Signed-off-by: Vedha Viyash <[email protected]>
@donyunardi
Copy link
Contributor

Thanks for prioritizing this. I will prep the CRAN release with this PR.
Please don't merge the PR until the package made it to CRAN.

@donyunardi
Copy link
Contributor

Submitted to CRAN.
Awaiting feedback.

@donyunardi
Copy link
Contributor

0.4.1 made it to CRAN
image

@vedhav let's merge this together tomorrow to make sure that I tag this properly when merged to main.

# Conflicts:
#	DESCRIPTION
#	NEWS.md
@vedhav
Copy link
Contributor Author

vedhav commented Apr 2, 2025

Sure, Dony. We will need help from @cicdguy so that we merge this PR without squashing. Because we will need the individual commits on the main branch so we can tag the previous commit.
We have to tag the commit 610898c as version 0.4.1

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ---------------------------------------
R/tm_a_pca.R                    890     890  0.00%    139-1162
R/tm_a_regression.R             775     775  0.00%    178-1058
R/tm_data_table.R               201     201  0.00%    100-349
R/tm_file_viewer.R              173     173  0.00%    47-255
R/tm_front_page.R               144     133  7.64%    77-247
R/tm_g_association.R            346     346  0.00%    159-580
R/tm_g_bivariate.R              698     434  37.82%   331-826, 867, 978, 995, 1013, 1024-1046
R/tm_g_distribution.R          1117    1117  0.00%    156-1420
R/tm_g_response.R               369     369  0.00%    177-625
R/tm_g_scatterplot.R            734     734  0.00%    260-1098
R/tm_g_scatterplotmatrix.R      297     278  6.40%    198-532, 593, 607
R/tm_missing_data.R            1119    1119  0.00%    124-1420
R/tm_outliers.R                1042    1042  0.00%    163-1356
R/tm_t_crosstable.R             264     264  0.00%    163-475
R/tm_variable_browser.R         805     800  0.62%    89-1046, 1084-1267
R/utils.R                       151     135  10.60%   87-272, 302-338, 350-359, 364, 378-397
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          9127    8812  3.45%

Diff against main

Filename                 Stmts    Miss  Cover
---------------------  -------  ------  --------
R/tm_a_pca.R                +2      +2  +100.00%
R/tm_a_regression.R         -1      -1  +100.00%
R/tm_g_association.R        -1      -1  +100.00%
R/tm_g_bivariate.R          -1      -1  +0.05%
R/tm_g_distribution.R       -1      -1  +100.00%
R/tm_g_response.R           -1      -1  +100.00%
R/tm_g_scatterplot.R        +2      +2  +100.00%
R/tm_t_crosstable.R         +2      +2  +100.00%
TOTAL                       +1      +1  -0.00%

Results for commit: 9395313

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

Unit Tests Summary

  1 files  22 suites   1s ⏱️
144 tests 29 ✅ 115 💤 0 ❌
182 runs  67 ✅ 115 💤 0 ❌

Results for commit 9395313.

♻️ This comment has been updated with latest results.

@vedhav vedhav merged commit e8dc0e8 into main Apr 2, 2025
29 checks passed
@vedhav vedhav deleted the 870-hot-fix@to-cran branch April 2, 2025 17:18
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: output is not updated when filter is added

5 participants