[SYCL] Do not pipe command output after redirect in no-xfail-without-tracker.cpp #15871
Conversation
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| // verify that against the reference | ||
| // - ...and check if the list of improperly XFAIL-ed tests needs to be updated. | ||
| // | ||
| // RUN: grep -rI "XFAIL:" %S/../test-e2e \ |
There was a problem hiding this comment.
Correct.
The trailing redundant part ' | \$' proposed to be removed is just a blindly copied pasted ending with pipe from the previous lines. The line 31 has the ending part of the pipeline with first command started on line 28, so the | pipe with \ ending are redundant in the end of line 31 because next lines have no next part to be delimited with as done above.
There was a problem hiding this comment.
delimiter with pipeline " | \\(\s+)?" used around 60 times in llvm tests including SYCL
There was a problem hiding this comment.
Trailing \ should not be removed, because they are used to break multi-line commands. For example line 29 has no sense if it is launched standalone.
I'm also mostly sure that we can't remove \ in commands which use |, simply because of the way how lit handles those. Even though it looks like a shell script, it is strictly speaking isn't a shell script.
|
@PietroGhg I just merged #15835 so I think we can close this? |
Agreed, thanks @sarnex |
4 participants
The test used
>to redirectstdoutto a file, and then pipes (|) intocat, I'm not sure if it is intended but this PR removes the|so thatcatworks on the file created by the previous command.