Skip to content

[SYCL] Do not pipe command output after redirect in no-xfail-without-tracker.cpp #15871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SYCL] Do not pipe command output after redirect in no-xfail-without-tracker.cpp #15871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/test/no-xfail-without-tracker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
// RUN: grep -rI "XFAIL:" %S/../test-e2e \
Copy link
Contributor

@AndreiZibrov AndreiZibrov Oct 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct.
The trailing redundant part ' | \$' proposed to be removed is just a blindly copied pasted ending with pipe from the previous lines. The line 31 has the ending part of the pipeline with first command started on line 28, so the | pipe with \ ending are redundant in the end of line 31 because next lines have no next part to be delimited with as done above.

Copy link
Contributor

@AndreiZibrov AndreiZibrov Oct 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delimiter with pipeline " | \\(\s+)?" used around 60 times in llvm tests including SYCL

Copy link
Contributor

@AlexeySachkov AlexeySachkov Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing \ should not be removed, because they are used to break multi-line commands. For example line 29 has no sense if it is launched standalone.
I'm also mostly sure that we can't remove \ in commands which use |, simply because of the way how lit handles those. Even though it looks like a shell script, it is strictly speaking isn't a shell script.

// RUN: -A 1 --include=*.c --include=*.cpp --no-group-separator | \
// RUN: grep -v "XFAIL:" | \
// RUN: grep -Pv "XFAIL-TRACKER:\s+(?:https://github.com/[\w\d-]+/[\w\d-]+/issues/[\d]+)|(?:[\w]+-[\d]+)" > %t | \
// RUN: grep -Pv "XFAIL-TRACKER:\s+(?:https://github.com/[\w\d-]+/[\w\d-]+/issues/[\d]+)|(?:[\w]+-[\d]+)" > %t
// RUN: cat %t | wc -l | FileCheck %s --check-prefix NUMBER-OF-XFAIL-WITHOUT-TRACKER
// RUN: cat %t | sed 's/\.cpp.*/.cpp/' | sort | FileCheck %s
//
Expand Down
Loading