Try out jenkins-io-components

[halkeye]

Trying out the web components

• active links definitely need refactoring.
• Search box needs to actually be setup

Optional

• Probably can load it earlier (deferred) so we don't get the flash of a header
• Probably don't need the polyfills depending on which browers we are okay being degraded and without header/foheader
• Move GitHub orgs
• use updatecli instead of always linking to recent package on unpkg?

[halkeye]

@MarkEWaite @lemeurherve

Getting closer

[halkeye]

Exciting.

Active links are highlighted nicely now.

Now decisions need to be made.

[halkeye]

okay https://deploy-preview-5668--jenkins-io-site-pr.netlify.app/?locale=fr-CA is working (only cdf menu has any translation). The locales files are a bit rough, but i think i have solutions, but thats a later problem.

[MarkEWaite]

@halkeye this looks great to me. Are there remaining steps to be taken before it is merged?

@kmartens27 could you explore the preview site as well in order to see if you see anything amiss. I used Windows and Chrome. Your macOS may show something different.,

[halkeye]

@halkeye this looks great to me. Are there remaining steps to be taken before it is merged?

nope, nothing blocking. If we like it, i'd like to start converting more things.

I have A date time box - https://jenkins-infra.github.io/jenkins-io-components/?path=/story/example-datetimebox--with-start-time-iso that could be reused everwhere instead of just events
I have social media icons - https://jenkins-infra.github.io/jenkins-io-components/?path=/story/example-socialmediabuttons--combined so it could be used on author tags
I have the embedded weather icons / voting that could be used too - https://jenkins-infra.github.io/jenkins-io-components/?path=/story/example-changelogratings--all-args

None of which I want to do before this merged, but the more re-usable components, the easier it will be for future projects/redesigns (web components are entirely self contained, so css issues won't be an issue)

[kmartens27]

everything looks good from my side as well @MarkEWaite & @halkeye, no oddities for a macOS set up that I could find!

[halkeye]

Oh! I'm no longer on board, I can't merge!

Can someone else merge then.

[kmartens27]

all set @halkeye!

[NotMyFault]

I really like the extra attribution for menu topics, but is there a reasoning, why the topmost item isn't highlighted if it's a dropdown list?

[timja]

Blog link on plugins.jenkins.io leads to 404:
https://plugins.jenkins.io/node

[timja]

tbh most links on plugins.jenkins.io 404

[halkeye]

oops, i have to merge the other two prs now

[halkeye]

tbh most links on plugins.jenkins.io 404

jenkins-infra/plugin-site#1256 will automerge
jenkins-infra/stories#18 is merged

I really like the extra attribution for menu topics, but is there a reasoning, why the topmost item isn't highlighted if it's a dropdown list?

time mostly, i found a bunch of that logic a bit more frustrating than I expected, so left it as a straight "if urls match == active", but should be updatable at some point to say "if any active children, then active too"

[halkeye]

Blog link on plugins.jenkins.io leads to 404:

fixed!

[zbynek]

wrong links (header and footer) now on https://updates.jenkins.io/

[halkeye]

I don't know anything about that site's process. Essentially the property attribute for jio-navbar and jio-footer needs to be updated. I kinda feel like with the web components, we probably don't need to be generating that site all the time, it'll just always have the latest nav.

[halkeye]

Okay, found https://github.com/jenkins-infra/update-center2/blob/2c78f6ee4d125893a6934bcf24d62dde62a4be42/site/generate.sh#L168

jenkins-infra/update-center2#670 should address it

[NotMyFault]

Do you plan to transition get.jenkins.io from whatever it uses now to the new components too?

Looks like that's the last occurrence.