fix: Support web components for nav and footer on jenkins.io#670
fix: Support web components for nav and footer on jenkins.io#670halkeye wants to merge 6 commits intojenkins-infra:masterfrom
Conversation
daniel-beck
left a comment
There was a problem hiding this comment.
Thanks for the adaptation.
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
|
@daniel-beck it'll be at least a day before i can poke at this again (work then personal meeting), do you want to make the changes you requested yourself? otherwise i'll try to fix things up after everything tonight, but likely not till tomorrow afternoon for me |
I don't think I'll have time before then. Thanks for checking! |
* Switch to cat | sed to make it more osx portable * Document with usage when bad parameters
|
Cleanup generate jenkins io template
I opted out of having Improve This Page and Report a Problem links on the footer but they are simple html attributes if we want them. |
There was a problem hiding this comment.
https://github.com/jenkins-infra/update-center2/blob/master/src/main/java/io/jenkins/update_center/JenkinsIndexTemplateProvider.java needs to be changed as well for pages like https://updates.jenkins.io/download/war/ or https://updates.jenkins.io/download/plugins/matrix-auth/
Called via
update-center2/site/generate.sh
Line 93 in f39efba
jenkins-infra/jenkins.io#5668 (comment)
makes sure property is set right for components
also don't include report a problem / improve this page (but easy to add if desired)