Remove character set dependency from assertion#150
Merged
MarkEWaite merged 1 commit intojenkinsci:masterfrom Mar 10, 2025
Merged
Remove character set dependency from assertion#150MarkEWaite merged 1 commit intojenkinsci:masterfrom
MarkEWaite merged 1 commit intojenkinsci:masterfrom
Conversation
The assertion is intended to confirm that the correct item is in the list, not that the current environment is using a specific character set. Removes the non-ASCII character from the assertion while retaining the SHA-1 segment and the date string.
MarkEWaite
added a commit
to MarkEWaite/repository-permissions-updater
that referenced
this pull request
Mar 23, 2025
Pull request in the repository that will enable CD: * jenkinsci/git-parameter-plugin#153 Pull requests that will be delivered by the automated release: * jenkinsci/git-parameter-plugin#151 * jenkinsci/git-parameter-plugin#150 * jenkinsci/git-parameter-plugin#147
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove character set dependency from assertion
The assertion is intended to confirm that the correct item is in the list, not that the current environment is using a specific character set. Removes the non-ASCII character from the assertion while retaining the SHA-1 segment and the date string.
Testing done
Confirmed that automated tests pass on Linux with Java 21. Rely on ci.jenkins.io to confirm Windows with Java 11.
Submitter checklist