-
Notifications
You must be signed in to change notification settings - Fork 5
Align Create app version command
#28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…into add_version_release
Unit Tests Results121 tests +36 121 ✅ +36 0s ⏱️ ±0s Results for commit fafcdff. ± Comparison against base commit 2e307e8. This pull request removes 2 and adds 38 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
…improved structure and readability
2d2f81d to
693f884
Compare
| }, | ||
| { | ||
| Name: "version", | ||
| Description: "The version number (in SemVer format) for the new application version.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we validate SemVer already in CLI or do we rely on AppTrust to throw an error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We validate in AppTrust, i didn't see any logic to do so inside the CLI.
I guess we could add it
| Version: ctx.Arguments[0], | ||
| Packages: packages, | ||
| }, nil | ||
| if buildsStr := ctx.GetStringFlagValue(commands.BuildsFlag); buildsStr != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be better to use IsFlagSet instead of GetStringFlagValue, here and in the following ifs below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would still need to call getValue if it exists
eff77ed to
918e18c
Compare
918e18c to
1c5c825
Compare

mainbranch.go vet ./....go fmt ./....PR: Enhance
version-createCommand for AppTrust CLISummary
This PR significantly improves the
version-createcommand in the AppTrust CLI, aligning it with the latest product specification and enhancing usability, flexibility, and correctness.Also added tests for specfiles
Key Changes
Command Arguments & Help Output
app-key: The application key of the application for which the version is being created.version: The version number (in SemVer format) for the new application version.New and Updated Flags
--tag: Associate a tag with the version.--builds: List of builds in the format'name1:number1[:timestamp1];name2:number2[:timestamp2]'.--release-bundles: List of release bundles in the format'name1:version1;name2:version2'.--source-version: Source versions in the format'app1:version1;app2:version2'.--specand--spec-varsAPI Route Update
Before
After