Skip to content

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Nov 26, 2025

These files were deprecated many releases ago.

I believe downstream code should be using the new packages

@knative-prow
Copy link

knative-prow bot commented Nov 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from dsimansk and skonto November 26, 2025 21:24
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 26, 2025
@dprotaso
Copy link
Member Author

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2025
@dprotaso dprotaso changed the title remove deprecated files [wip] remove deprecated files Nov 26, 2025
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2025
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.33%. Comparing base (137d136) to head (1876094).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1102      +/-   ##
==========================================
+ Coverage   93.14%   93.33%   +0.18%     
==========================================
  Files          36       35       -1     
  Lines        1007     1005       -2     
==========================================
  Hits          938      938              
+ Misses         55       53       -2     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@linkvt
Copy link

linkvt commented Nov 27, 2025

I'll leave an LGTM as the change looks good and as the failing tests can be retriggered without resetting my LGTM when the downstream PRs are merged.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2025
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2025
@dprotaso dprotaso changed the title [wip] remove deprecated files remove deprecated files Nov 27, 2025
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 27, 2025
@dprotaso
Copy link
Member Author

dropped the extra file

cc @linkvt for another LGTM

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2025
@linkvt
Copy link

linkvt commented Nov 27, 2025

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2025
@knative-prow knative-prow bot merged commit 5082b02 into knative:main Nov 27, 2025
27 checks passed
@dprotaso dprotaso deleted the remove-deprecated-files branch November 27, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants