-
Notifications
You must be signed in to change notification settings - Fork 78
remove deprecated files #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove deprecated files #1102
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1102 +/- ##
==========================================
+ Coverage 93.14% 93.33% +0.18%
==========================================
Files 36 35 -1
Lines 1007 1005 -2
==========================================
Hits 938 938
+ Misses 55 53 -2
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'll leave an LGTM as the change looks good and as the failing tests can be retriggered without resetting my LGTM when the downstream PRs are merged. /lgtm |
|
dropped the extra file cc @linkvt for another LGTM /hold cancel |
|
/lgtm |
These files were deprecated many releases ago.
I believe downstream code should be using the new packages