Add IfVolume stencil enable state for inheritance.#65
Merged
Conversation
komadori
force-pushed
the
stencil-control
branch
from
ebe7568 to
6b799ca
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to required components, this crate encouraged users to add both a volume and a stencil to their entities by offering a standard bundle which included both components. When I migrated the crate away from bundles I considered making the
OutlineStencila required component of theOutlineVolume, but decided against this as I feared the stencil would counter-intuitively linger if the volume component was removed. Instead, I relied on making default state of the stencil in aComputedOutlinebeing enabled. However, in practice this has turned out to have the exact same problem as theComputedOutlinecomponents lingers and enables the stencil.This PR changes the stencil enable flag into an enum. The
Defaultvalue remainsAlwaysif the component is added explicitly, but the implicit default is a newIfVolumesettings. This only enables the stencil if the volume is enabled so that aComputedOutlinewith no other components has no effect.