Remove viper from minikube and driver packages - part 1

[nirs]

Currently we use viper outside of cmd/minikube/cmd package in pkg/minikube/** and pkg/drivers/**. This introduce 2 issues:

• Make the code hard to test by using global state. For example for testing interactive mode we must use viper.SetBool("interactive", false). This may break another test assuming interactive mode.
• Error prone - since the flag names are private constants in the cmd/minikube/cmd package, we use strings (e.g. "interactive") in other package. A typo in the flag name will silently provide the wrong value, ignoring the user request.

This is the first part in removing viper calls outside of the cmd/minikube/cmd package.

Preparations

• run: Introduce minikube/run and cmd/flags packages - the basic infrastructure for passing options from cmd/minikube/cmd to other packages.
• run: Pass options to drivers - big change passing options from most commands that load or check driver status.
  • This is a pretty big commit but it is hard to split it.

Removals

• vment: Remove viper interactive check - remove viper.GetBool("interactive") check in vment.ValidateHelper()
• firewall: Remove viper interactive check - remove viper.GetBool("interactive") check in firewall.UnblockBootpd()
• notify: Remove viper interactive checks - remove viper.GetBool("interactive") check in notify.shouldCheckURLVersion()
• run: Remove viper.GetBool("download-only") checks in cmd and minikube packages

Part-of #21670

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nirs
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nirs]

/cc @ComradeProgrammer
/cc @afbjorklund

[nirs]

/ok-to-test

[medyagh]

thank you for doing this ! this is gonna make minikube development much safer (and less suprises)

[medyagh]

/ok-to-test

[medyagh]

we should make to document this in the contributors guide
to never make a viper call outside CMD packages

[k8s-ci-robot]

@nirs: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-minikube-integration	1b58c48	link	true	/test pull-minikube-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[minikube-pr-bot]

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21683 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 43.6s    │ 44.3s                  │
│ enable ingress │ 16.2s    │ 16.5s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 41.7s 42.1s 45.9s 43.6s 44.7s
Times for minikube (PR 21683) start: 45.3s 44.4s 44.3s 45.2s 42.2s

Times for minikube ingress: 15.8s 16.4s 16.9s 15.8s 15.9s
Times for minikube (PR 21683) ingress: 17.3s 16.4s 15.9s 16.8s 15.9s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21683 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 23.4s    │ 23.6s                  │
│ enable ingress │ 11.9s    │ 12.5s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 23.4s 22.7s 22.8s 25.4s 22.7s
Times for minikube (PR 21683) start: 22.0s 26.7s 23.7s 23.6s 22.2s

Times for minikube ingress: 12.7s 11.7s 13.7s 10.7s 10.7s
Times for minikube (PR 21683) ingress: 12.7s 12.7s 11.7s 13.7s 11.6s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21683 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 21.6s    │ 21.7s                  │
│ enable ingress │ 21.0s    │ 20.4s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube ingress: 20.2s 20.1s 22.2s 21.1s 21.2s
Times for minikube (PR 21683) ingress: 21.1s 20.1s 20.1s 20.2s 20.2s

Times for minikube start: 23.2s 20.2s 20.4s 24.2s 20.1s
Times for minikube (PR 21683) start: 20.6s 24.0s 20.5s 21.4s 21.7s

[minikube-pr-bot]

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment	Test Name	Flake Rate
Docker_Linux_containerd (2 failed)	TestFunctional/parallel/DashboardCmd(gopogh)	0.00% (chart)
Docker_Linux_containerd (2 failed)	TestKubernetesUpgrade(gopogh)	0.00% (chart)
KVM_Linux_crio (4 failed)	TestFunctional/parallel/ImageCommands/ImageRemove(gopogh)	2.50% (chart)

Besides the following environments also have failed tests:

• Docker_Linux_crio_arm64: 37 failed (gopogh)

• Docker_Linux_crio: 41 failed (gopogh)

To see the flake rates of all tests by environment, click here.