[10.x][Algolia] Support numeric 'whereNotIn' to prevent silent failures#959
Merged
taylorotwell merged 2 commits intolaravel:10.xfrom Jan 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Algolia] Support numeric
whereNotInto prevent silent failuresDescription
Currently, the Algolia engine silently fails when
whereNotInis used. The Builder accepts the method call, butAlgoliaEnginecompletely ignores the exclusion list, returning records that the developer explicitly intended to hide.This PR implements
whereNotInsupport using Algolia'snumericFilters, bringing parity withwhereandwhereIn.Before
After
Technical Implementation
Since Algolia's
numericFilterslacks a native "NOT IN" operator, we simulate it usingANDlogic:whereIn(Existing): Maps to a nested array[['id=1', 'id=2']](interpreted as OR).whereNotIn(New): UsesflatMapto generate a top-level list['id!=1', 'id!=2'](interpreted as AND).Note: Consistent with the existing engine implementation, this supports numeric values only.
Tests
Comprehensive tests were added to
Algolia3EngineTestandAlgolia4EngineTestto verify:whereNotIn('foo', [1, 2])generates['foo!=1', 'foo!=2'].where,whereIn, andwhereNotInwork correctly when combined in a single query.Benefit to end users
Developers can now reliably use
whereNotInto exclude specific numeric records (e.g., status codes, IDs) from their search results without needing manual post-processing. It eliminates a dangerous silent failure where sensitive or unwanted data could be exposed.Reasons it does not break any existing features
This change is purely additive. It processes
whereNotInconstraints which were previously ignored. ExistingwhereandwhereInfunctionality remains untouched, and applications not usingwhereNotInwill experience no change in behavior.