fix(stream): garbage-collect deregistered streams in Shared::accept#5999
Merged
mergify[bot] merged 4 commits intolibp2p:masterfrom Apr 21, 2025
Merged
fix(stream): garbage-collect deregistered streams in Shared::accept#5999mergify[bot] merged 4 commits intolibp2p:masterfrom
Shared::accept#5999mergify[bot] merged 4 commits intolibp2p:masterfrom
Conversation
PoulavBhowmick03
changed the title
PoulavBhowmick03
changed the title
PoulavBhowmick03
changed the title
elenaf9
approved these changes
Apr 21, 2025
Member
elenaf9
left a comment
elenaf9
left a comment
There was a problem hiding this comment.
Thanks @PoulavBhowmick03!
Could you please also bump the libp2p-stream version to 0.3.0-alpha.1 and add a new CHANGELOG entry?
Contributor
Author
Sure |
Contributor
Author
|
@elenaf9 can you ptal? thanks! |
elenaf9
changed the title
Stream::accept
elenaf9
reviewed
Apr 21, 2025
elenaf9
changed the title
Stream::acceptShared::accept
elenaf9
reviewed
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related #5963
Fixes #5963
As per the discussion in the comments of the issue, I have modified
Shared::acceptto remove deregistered inbound protocols similar to whatShared::supported_inbound_protocolsdoes, in order to potentially fix the problem of dropping IncomingStreams does not deregister inbound protocolNotes & open questions
Change checklist