Skip to content

fix(stream): garbage-collect deregistered streams in Shared::accept #5999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 4 commits into from
Apr 21, 2025
Merged

fix(stream): garbage-collect deregistered streams in Shared::accept #5999

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef03536
modified Shared::accept to remove deregistered inbound protocols
PoulavBhowmick03 Apr 21, 2025
117d48e
bumped the to and added a CHANGELOG entry
PoulavBhowmick03 Apr 21, 2025
f5b235e
Update protocols/stream/CHANGELOG.md
elenaf9 Apr 21, 2025
2f077b2
Update protocols/stream/CHANGELOG.md
elenaf9 Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions protocols/stream/src/shared.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ impl Shared {
&mut self,
protocol: StreamProtocol,
) -> Result<IncomingStreams, AlreadyRegistered> {
self.supported_inbound_protocols
.retain(|_, sender| !sender.is_closed());

if self.supported_inbound_protocols.contains_key(&protocol) {
return Err(AlreadyRegistered);
}
Expand Down
Loading