staticaddr: lock mutex for active deposits access #902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhandras
reviewed
Mar 20, 2025
staticaddr/deposit/manager.go
Outdated
| return ctx.Err() | ||
| } | ||
| } | ||
| m.mu.Unlock() |
Member
There was a problem hiding this comment.
Unlock should also happen above where we return on ctx.Done()
Collaborator
Author
There was a problem hiding this comment.
re-structured the code.
hieblmi
force-pushed
the
fix-deadlock
branch
2 times, most recently
from
c50edea to
7407a61
Compare
starius
approved these changes
Mar 21, 2025
| } | ||
| } | ||
| }() | ||
| }(depoFsm) |
Collaborator
There was a problem hiding this comment.
Why is this passing-as-an-argument needed? Previous version seems also ok.
Collaborator
Author
There was a problem hiding this comment.
usually this pattern is better within loops, but I also find in more clear, so keeping it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes race conditions in the static address withdrawal manager.