Fix a few bugs in net up --kubernetes #4516
Merged
+2
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
afck
approved these changes
Sep 9, 2025
Contributor
|
Does this fix #4494? |
Contributor
Author
|
It does, yes. The tests all pass for me locally now. But on CI for #4410 they still don't for some reason, but it's probably a different unrelated issue 🤔 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some of the configs were wrong, as well as the port forwarding, making notifications stop working and 3 of the tests fail.
Proposal
Do the required fixes (wrong address, port forwarding, etc). Fixes #4494
Test Plan
Started a local network with
net up --kubernetes, ran e2e tests against it, they all pass.Release Plan