[Flang] Use a module directory to avoid race condition

[kiranchandramohan]

Use a module directory in a test that uses another fortran test to avoid race conditions in module creation.

[llvmbot]

@llvm/pr-subscribers-flang-fir-hlfir

Author: Kiran Chandramohan (kiranchandramohan)

Changes

Use a module directory in a test that uses another fortran test to avoid race conditions in module creation.

---

Full diff: https://github.com/llvm/llvm-project/pull/123215.diff

1 Files Affected:

• (modified) flang/test/Lower/module_use.f90 (+3-2)

diff --git a/flang/test/Lower/module_use.f90 b/flang/test/Lower/module_use.f90
index ad43865470b681..c7b29df882fadc 100644
--- a/flang/test/Lower/module_use.f90
+++ b/flang/test/Lower/module_use.f90
@@ -1,5 +1,6 @@
-! RUN: bbc -emit-fir %S/module_definition.f90
-! RUN: bbc -emit-fir %s -o - | FileCheck %s
+! RUN: rm -fr %t && mkdir %t
+! RUN: bbc -emit-fir -module %t %S/module_definition.f90
+! RUN: bbc -emit-fir -J %t %s -o - | FileCheck %s
 
 ! Test use of module data not defined in this file.
 ! The modules are defined in module_definition.f90

[tarunprabhu]

Other than the -p suggestion, this looks ok. Hopefully it fixes the other issue.

[tarunprabhu]

Maybe mkdir -p would be safer, just in case there is something that doesn't exist along the way

[luporl]

Won't this break Windows bots?

[kiranchandramohan]

We have other similar tests that seem to work OK.
https://github.com/llvm/llvm-project/blob/main/flang/test/Driver/write-module.f90

[luporl]

Hmm, some other tests use rm and mkdir without excluding Windows, so I guess this is fine.
Sorry for the noise.

[jeanPerier]

Thanks Kiran!