Skip to content

[Flang] Use a module directory to avoid race condition #123215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2025
Merged

[Flang] Use a module directory to avoid race condition #123215

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fdbe07
[Flang] Use a module directory to avoid race condition
kiranchandramohan Jan 16, 2025
3aa9057
Create parent directories if necessary
kiranchandramohan Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions flang/test/Lower/module_use.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
! RUN: bbc -emit-fir %S/module_definition.f90
! RUN: bbc -emit-fir %s -o - | FileCheck %s
! RUN: rm -fr %t && mkdir %t
Copy link
Contributor

@tarunprabhu tarunprabhu Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mkdir -p would be safer, just in case there is something that doesn't exist along the way

Copy link
Contributor

@luporl luporl Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this break Windows bots?

Copy link
Contributor Author

@kiranchandramohan kiranchandramohan Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have other similar tests that seem to work OK.
https://github.com/llvm/llvm-project/blob/main/flang/test/Driver/write-module.f90

Copy link
Contributor

@luporl luporl Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, some other tests use rm and mkdir without excluding Windows, so I guess this is fine.
Sorry for the noise.

! RUN: bbc -emit-fir -module %t %S/module_definition.f90
! RUN: bbc -emit-fir -J %t %s -o - | FileCheck %s

! Test use of module data not defined in this file.
! The modules are defined in module_definition.f90
Expand Down
Loading