[CIR] Fix NYI AAPCS bit-fields by skipping unsupported case #145560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang Author: None (Andres-Salamanca) ChangesThis PR addresses the error mentioned in #145067 (comment), which occurs on ARM when handling an unsupported bit-field case. The patch removes the error and replaces it with an assert, marking the missing feature. Full diff: https://github.com/llvm/llvm-project/pull/145560.diff 1 Files Affected:
diff --git a/clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp b/clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp
index 349c6e75ce36c..4643f6c1a9cef 100644
--- a/clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp
+++ b/clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp
@@ -778,10 +778,8 @@ void CIRRecordLowering::computeVolatileBitfields() {
!cirGenTypes.getCGModule().getCodeGenOpts().AAPCSBitfieldWidth)
return;
- for ([[maybe_unused]] auto &I : bitFields) {
+ for ([[maybe_unused]] auto &I : bitFields)
assert(!cir::MissingFeatures::armComputeVolatileBitfields());
- cirGenTypes.getCGModule().errorNYI("NYI AAPCS bit-fields");
- }
}
void CIRRecordLowering::accumulateBases(const CXXRecordDecl *cxxRecordDecl) {
|
Member
|
@llvm/pr-subscribers-clangir Author: None (Andres-Salamanca) ChangesThis PR addresses the error mentioned in #145067 (comment), which occurs on ARM when handling an unsupported bit-field case. The patch removes the error and replaces it with an assert, marking the missing feature. Full diff: https://github.com/llvm/llvm-project/pull/145560.diff 1 Files Affected:
diff --git a/clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp b/clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp
index 349c6e75ce36c..4643f6c1a9cef 100644
--- a/clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp
+++ b/clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp
@@ -778,10 +778,8 @@ void CIRRecordLowering::computeVolatileBitfields() {
!cirGenTypes.getCGModule().getCodeGenOpts().AAPCSBitfieldWidth)
return;
- for ([[maybe_unused]] auto &I : bitFields) {
+ for ([[maybe_unused]] auto &I : bitFields)
assert(!cir::MissingFeatures::armComputeVolatileBitfields());
- cirGenTypes.getCGModule().errorNYI("NYI AAPCS bit-fields");
- }
}
void CIRRecordLowering::accumulateBases(const CXXRecordDecl *cxxRecordDecl) {
|
andykaylor
approved these changes
Jun 24, 2025
Contributor
andykaylor
left a comment
andykaylor
left a comment
There was a problem hiding this comment.
Thanks for handling this!
I have a minor comment, but let's just merge this as is to get the tests passing.
| return; | ||
|
|
||
| for ([[maybe_unused]] auto &I : bitFields) { | ||
| for ([[maybe_unused]] auto &I : bitFields) |
Contributor
There was a problem hiding this comment.
The for loop isn't really needed here.
DrSergei
pushed a commit
to DrSergei/llvm-project
that referenced
this pull request
Jun 24, 2025
) This PR addresses the error mentioned in llvm#145067 (comment), which occurs on ARM when handling an unsupported bit-field case. The patch removes the error and replaces it with an assert, marking the missing feature.
anthonyhatran
pushed a commit
to anthonyhatran/llvm-project
that referenced
this pull request
Jun 26, 2025
) This PR addresses the error mentioned in llvm#145067 (comment), which occurs on ARM when handling an unsupported bit-field case. The patch removes the error and replaces it with an assert, marking the missing feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the error mentioned in #145067 (comment), which occurs on ARM when handling an unsupported bit-field case. The patch removes the error and replaces it with an assert, marking the missing feature.