Skip to content

[CIR] Fix NYI AAPCS bit-fields by skipping unsupported case #145560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andykaylor merged 2 commits into from
Jun 24, 2025
Merged

[CIR] Fix NYI AAPCS bit-fields by skipping unsupported case #145560

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
171b2ab
Fix NYI AAPCS bit-fields by skipping unsupported case
Andres-Salamanca Jun 24, 2025
daa8327
Remove loop
Andres-Salamanca Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,10 +778,8 @@ void CIRRecordLowering::computeVolatileBitfields() {
!cirGenTypes.getCGModule().getCodeGenOpts().AAPCSBitfieldWidth)
return;

for ([[maybe_unused]] auto &I : bitFields) {
for ([[maybe_unused]] auto &I : bitFields)
Copy link
Contributor

@andykaylor andykaylor Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The for loop isn't really needed here.

Copy link
Member Author

@Andres-Salamanca Andres-Salamanca Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

assert(!cir::MissingFeatures::armComputeVolatileBitfields());
cirGenTypes.getCGModule().errorNYI("NYI AAPCS bit-fields");
}
}

void CIRRecordLowering::accumulateBases(const CXXRecordDecl *cxxRecordDecl) {
Expand Down
Loading