[MachO] Report error when there are too many sections #167418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are more than 255 sections, MachO object writer allows creation of object files which are potentially malformed. Currently, there is an assertion in object writer code that prevents it. But for distributions where assertions are turned on this still results in creation of malformed objects. Turning the assertion into an explicit fatal error.
Member
|
@llvm/pr-subscribers-llvm-mc Author: Prabhu Rajasekaran (Prabhuk) ChangesWhen there are more than 255 sections, MachO object writer allows Full diff: https://github.com/llvm/llvm-project/pull/167418.diff 1 Files Affected:
diff --git a/llvm/lib/MC/MachObjectWriter.cpp b/llvm/lib/MC/MachObjectWriter.cpp
index 39542bfbdd8e3..a6d87827795c2 100644
--- a/llvm/lib/MC/MachObjectWriter.cpp
+++ b/llvm/lib/MC/MachObjectWriter.cpp
@@ -646,7 +646,8 @@ void MachObjectWriter::computeSymbolTable(
LocalSymbolData.push_back(MSD);
} else {
MSD.SectionIndex = SectionIndexMap.lookup(&Symbol.getSection());
- assert(MSD.SectionIndex && "Invalid section index!");
+ if (!MSD.SectionIndex)
+ report_fatal_error("Invalid section index!");
LocalSymbolData.push_back(MSD);
}
}
|
Contributor
Author
|
Addresses issue: #167408 |
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Prabhuk
changed the title
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/144/builds/39919 Here is the relevant piece of the build log for the reference |
Contributor
|
Hello, we saw llvm test failure with this PR. Could you please take a look? Thanks! bot: https://lab.llvm.org/buildbot/#/builders/10/builds/17126 |
Contributor
Author
|
Apologies @Kewen12 -- sending out a fix right away. If that doesn't work I'll revert ASAP. |
Contributor
Author
|
#167598 -- please let me know if this fixes the failure. |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/160/builds/28102 Here is the relevant piece of the build log for the reference |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/180/builds/28242 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are more than 255 sections, MachO object writer allows
creation of object files which are potentially malformed. Currently,
there are assertions in object writer code that prevents this behavior.
But for distributions where assertions are turned off this still results in
creation of malformed object files. Turning assertions into explicit
errors.