Skip to content

[MachO] Report error when there are too many sections #167418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 11, 2025
Merged

[MachO] Report error when there are too many sections #167418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cdac1d8
[MachO] Fatal error on invalid section index
Prabhuk Nov 10, 2025
8e538af
Report error instead of fatal.
Prabhuk Nov 11, 2025
337589f
Add tests.
Prabhuk Nov 11, 2025
163ec46
Add inline comments.
Prabhuk Nov 11, 2025
4bef9c8
Fix formatting
Prabhuk Nov 11, 2025
f81f42d
Merge branch 'main' into patch_macho_writer
Prabhuk Nov 11, 2025
a3436e7
Fix test.
Prabhuk Nov 11, 2025
cabc1e9
Fix inline comment.
Prabhuk Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions llvm/lib/MC/MachObjectWriter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#include "llvm/Support/Debug.h"
#include "llvm/Support/ErrorHandling.h"
#include "llvm/Support/MathExtras.h"
#include "llvm/Support/SMLoc.h"
#include "llvm/Support/raw_ostream.h"
#include <algorithm>
#include <cassert>
Expand Down Expand Up @@ -584,7 +585,12 @@ void MachObjectWriter::computeSymbolTable(
unsigned Index = 1;
for (MCSection &Sec : Asm)
SectionIndexMap[&Sec] = Index++;
assert(Index <= 256 && "Too many sections!");

// Section indices begin from 1 in MachO. Only sections 1-255 can be indexed
// into section symbols. Referencing a section with index larger than 255 will
// not set n_sect for these symbols.
if (Index > 255)
getContext().reportError(SMLoc(), "Too many sections!");

// Build the string table.
for (const MCSymbol &Symbol : Asm.symbols()) {
Expand Down Expand Up @@ -621,7 +627,8 @@ void MachObjectWriter::computeSymbolTable(
ExternalSymbolData.push_back(MSD);
} else {
MSD.SectionIndex = SectionIndexMap.lookup(&Symbol.getSection());
assert(MSD.SectionIndex && "Invalid section index!");
if (!MSD.SectionIndex)
getContext().reportError(SMLoc(), "Invalid section index!");
ExternalSymbolData.push_back(MSD);
}
}
Expand All @@ -645,7 +652,8 @@ void MachObjectWriter::computeSymbolTable(
LocalSymbolData.push_back(MSD);
} else {
MSD.SectionIndex = SectionIndexMap.lookup(&Symbol.getSection());
assert(MSD.SectionIndex && "Invalid section index!");
if (!MSD.SectionIndex)
getContext().reportError(SMLoc(), "Invalid section index!");
LocalSymbolData.push_back(MSD);
}
}
Expand Down
Loading
Loading