Remove TODO comments about unique ID generation in XY visualization warnings

[Copilot]

Summary

Resolved TODO comments questioning the correctness of unique ID generation for mixed logarithmic scale warnings in XY visualization. Analysis confirmed the current implementation is correct—unique IDs are properly scoped per axis (groupId) and per dimension (accessor).

Changes

• Replaced two TODO comments with explanatory comments clarifying why the unique ID construction is appropriate
• Lines 1023 and 1053 in visualization.tsx

Before:

// TODO: can we push the group into the metadata and use a correct unique ID here?
uniqueId: `${XY_MIXED_LOG_SCALE}${groupId}`,

After:

// Create a unique ID per axis (left/right) since each axis can independently
// have mixed positive/negative values when using logarithmic scale
uniqueId: `${XY_MIXED_LOG_SCALE}${groupId}`,

The implementation correctly uses string interpolation with groupId ('left'/'right') for axis-level warnings and accessor (column ID) for dimension-level warnings. Constants in user_messages_ids.ts have trailing hyphens ('xy_mixed_log_scale-groupid-') confirming the design intent for concatenation.

Checklist

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
• Flaky Test Runner was used on any tests changed
• The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
• Review the backport guidelines and apply applicable backport:* labels.

Identify risks

• No risks. Comment-only changes with no functional impact.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• ci-stats.kibana.dev
  • Triggering command: /home/REDACTED/.nvm/versions/node/v22.17.1/bin/node --no-experimental-require-module scripts/kbn bootstrap --quiet (dns block)
• download.cypress.io
  • Triggering command: /home/REDACTED/.nvm/versions/node/v22.17.1/bin/node index.js --exec install (dns block)
• googlechromelabs.github.io
  • Triggering command: /home/REDACTED/.nvm/versions/node/v22.17.1/bin/node install.js (dns block)
• iojs.org
  • Triggering command: curl -q --fail --compressed -L -s REDACTED -o - (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

Work on TODO: check that does it mean (from x-pack/platform/plugins/shared/lens/public/visualizations/xy/visualization.tsx)

Created from VS Code via the GitHub Pull Request extension.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.