Skip to content

Remove TODO comments about unique ID generation in XY visualization warnings #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: 2025_11_13-multi_terms_3
Choose a base branch
from
+4 −2
Draft

Remove TODO comments about unique ID generation in XY visualization warnings #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c03025d
Initial plan
Copilot Nov 13, 2025
48e1307
Resolve TODO comments about unique IDs in XY visualization warnings
Copilot Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions x-pack/platform/plugins/shared/lens/public/visualizations/xy/visualization.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,7 +1020,8 @@ export const getXyVisualization = ({
const { groupId } = axisGroup;

warnings.push({
// TODO: can we push the group into the metadata and use a correct unique ID here?
// Create a unique ID per axis (left/right) since each axis can independently
// have mixed positive/negative values when using logarithmic scale
uniqueId: `${XY_MIXED_LOG_SCALE}${groupId}`,
severity: 'warning',
shortMessage: '',
Expand Down Expand Up @@ -1050,7 +1051,8 @@ export const getXyVisualization = ({

axisGroup.mixedDomainSeries.forEach(({ accessor }) => {
warnings.push({
// TODO: can we push the group into the metadata and use a correct unique ID here?
// Create a unique ID per accessor (dimension) since each metric can independently
// have mixed positive/negative values when using logarithmic scale
uniqueId: `${XY_MIXED_LOG_SCALE_DIMENSION}${accessor}`,
severity: 'warning',
shortMessage: '',
Expand Down