Move to cpp folder #2763
Merged
Move to cpp folder #2763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
force-pushed
the
move-to-cpp-folder
branch
3 times, most recently
from
f0f78e7 to
1ffc9da
Compare
JonasVautherin
force-pushed
the
move-to-cpp-folder
branch
from
1ffc9da to
f146cb8
Compare
JonasVautherin
force-pushed
the
move-to-cpp-folder
branch
from
f146cb8 to
26956f8
Compare
JonasVautherin
force-pushed
the
move-to-cpp-folder
branch
from
08ced34 to
f6321a3
Compare
JonasVautherin
force-pushed
the
move-to-cpp-folder
branch
from
403fd14 to
ef788f7
Compare
Collaborator
|
@JonasVautherin this will probably be MAVSDK v4 when it merges, right? I mean technically it might not have to, but it feels like it could. |
julianoes
approved these changes
Feb 7, 2026
Collaborator
julianoes
left a comment
julianoes
left a comment
There was a problem hiding this comment.
Nice! I like folders.
Collaborator
Author
IMO the major version of a library should indicate if it will break the build or not. This just moves the projects into a subfolder, but the resulting compiled library should be exactly the same; it should not break the build of anyone. By bumping to v4, my concern would be that some people may not update because they don't want to fix compilation issues... |
julianoes
reviewed
Feb 8, 2026
| [submodule "mavsdk-proto"] | ||
| path = proto | ||
| url = https://github.com/ryanf55/MAVSDK-Proto.git | ||
| url = https://github.com/mavlink/MAVSDK-Proto.git |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see what the CI says...
Makes it look like this: