feat: bump supports-color from 8 to 10#5482
Closed
JoshuaKGoldberg wants to merge 5 commits intomochajs:mainfrom
Closed
feat: bump supports-color from 8 to 10#5482JoshuaKGoldberg wants to merge 5 commits intomochajs:mainfrom
JoshuaKGoldberg wants to merge 5 commits intomochajs:mainfrom
Conversation
5 tasks
This was referenced Oct 2, 2025
Member
|
new test failure :( |
Member
|
@JoshuaKGoldberg |
Member
Author
|
Ha yeah, I put these up as drafts with the intent of getting them to pass before requesting review. I was hoping there'd be no additional work but 🫠 |
5 tasks
Member
Author
|
Hmm. I can reproduce the CI failure locally in all of:
|
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5482 +/- ##
==========================================
+ Coverage 93.52% 93.66% +0.13%
==========================================
Files 57 57
Lines 4465 4465
Branches 918 918
==========================================
+ Hits 4176 4182 +6
+ Misses 289 283 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
I haven't had time for this for a while. Closing this in case someone else wants to try out the changes. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Bumps the package from
^8.1.1to^10.2.2.Interestingly, this increases the lockfile size for local development dependencies. This is because
supports-color@5.5.0is still referenced by:karmais tracked in 🛠 Repo: Stop using deprecatedkarmalibrary #5253nycis tracked in 🛠 Repo: Bump nyc from 15 to 17 #5481💖