chore(components): update Code to latest; adjust component usage to new interface COMPASS-9925 #7424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
commented
Oct 6, 2025
| @@ -9643,6 +10107,482 @@ | |||
| "@leafygreen-ui/leafygreen-provider": "^5.0.4" | |||
| } | |||
| }, | |||
| "node_modules/@lg-tools/build": { | |||
There was a problem hiding this comment.
Most of 4k+ LoC changes in this file are due to this, seems like one of the packages that code pulls in has their whole build toolchain in dependencies. I think we should wait for LG team to fix this before merging (I asked about it in their channer)
gribnoysup
changed the title
lerouxb
approved these changes
Oct 6, 2025
gribnoysup
commented
Oct 6, 2025
| // exit details | ||
| // leafygreen autofocus triggers a tooltip on the error code element, | ||
| // "Tab" to remove the focus | ||
| await browser.keys('Tab'); |
There was a problem hiding this comment.
All three e2e tests failing after the update were caused by the leafygreen autofocus first thing in the modal behavior. The way of dealing with it is the same everywhere and it's more than two places, but I still didn't feel like it warrants a shared helper of some kind. Tell me if you have a different opinion on this
gagik
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates leafygreen Code component to latest to fix the copy button behavior: seems like in our current version it doesn't work inside the leafygreen chatbot element. Most notable changes are inside the "Export to language" feature: the Code component now doesn't include the code selector panel by default, so code around there had to be changed to account for that. Otherwise it's just slight visual changes in a couple of places:
Checks are passing, but pretty sure this will break tests that rely on testids, opening PR already to see how big the damage is.
Also package-lock update looks ridiculous because leafygreen deps are pulling in their whole toolchain inside our dependencies. I asked them about this and waiting for them to clean this up.