Skip to content

chore(components): update Code to latest; adjust component usage to new interface COMPASS-9925 #7424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore(components): update Code to latest; adjust component usage to new interface COMPASS-9925 #7424

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2fa1874
chore(components): update Code to latest; adjust component usage to n…
gribnoysup Oct 6, 2025
598e1d7
chore(e2e): update tests to deal with leafygreen autofocusing a butto…
gribnoysup Oct 6, 2025
fe2736d
chore(components): autofocus confirm button in error detail modal
gribnoysup Oct 7, 2025
990a80b
Merge remote-tracking branch 'origin/main' into update-leafygreen-cod…
gribnoysup Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/compass-e2e-tests/tests/collection-aggregations-tab.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,8 +675,13 @@ describe('Collection aggregations tab', function () {
await errorDetailsJson.waitForDisplayed();

// exit details
// leafygreen autofocus triggers a tooltip on the error code element,
// "Tab" to remove the focus
await browser.keys('Tab');
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All three e2e tests failing after the update were caused by the leafygreen autofocus first thing in the modal behavior. The way of dealing with it is the same everywhere and it's more than two places, but I still didn't feel like it warrants a shared helper of some kind. Tell me if you have a different opinion on this

// now click the close button
await browser.clickVisible(Selectors.confirmationModalConfirmButton());
await errorElement.waitForDisplayed();
// wait for the modal to go away
await errorDetailsJson.waitForDisplayed({ reverse: true });
});
});

Expand Down
7 changes: 6 additions & 1 deletion packages/compass-e2e-tests/tests/collection-documents-tab.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,8 +731,13 @@ FindIterable<Document> result = collection.find(filter);`);
await errorDetailsJson.waitForDisplayed();

// exit details
// leafygreen autofocus triggers a tooltip on the error code element,
// "Tab" to remove the focus
await browser.keys('Tab');
// now click the close button
await browser.clickVisible(Selectors.confirmationModalConfirmButton());
await errorElement.waitForDisplayed();
// wait for the modal to go away
await errorDetailsJson.waitForDisplayed({ reverse: true });
});

describe('Editing', function () {
Expand Down
6 changes: 6 additions & 0 deletions packages/compass-e2e-tests/tests/collection-import.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,13 @@ describe('Collection import', function () {
expect(await errorDetailsJson.getText()).to.include(
'schemaRulesNotSatisfied'
);
// leafygreen autofocus triggers a tooltip on the error code element,
// "Tab" to remove the focus
await browser.keys('Tab');
// now click the close button
await browser.clickVisible(Selectors.confirmationModalConfirmButton());
// wait for the modal to go away
await errorDetailsJson.waitForDisplayed({ reverse: true });
});

it('with CSV + abort on error unchecked, it includes the details in a file', async function () {
Expand Down